Skip to content

Remove firebase OAuth API endpoints #9144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

PineappleIOnic
Copy link
Contributor

What does this PR do?

The firebase migration code had the ability to one click migrate using Sign in with Google and OAuth2 but Google blocked our application from accessing the required scopes to achieve this so this functionality was never used. This PR removes those OAuth API endpoints.

Test Plan

All functionality should work as previously expected due to these API's never being used.

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3 3.12.7-r0 CVE-2024-12254 HIGH
python3-pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3-pycache-pyc0 3.12.7-r0 CVE-2024-12254 HIGH
golang.org/x/crypto v0.26.0 CVE-2024-45337 CRITICAL
golang.org/x/net v0.28.0 CVE-2024-45338 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link

pkg-pr-new bot commented Dec 30, 2024

Open in Stackblitz

npm i https://pkg.pr.new/appwrite/appwrite/@appwrite.io/console@9144

commit: 26bac5a

Copy link

✨ Benchmark results

  • Requests per second: 1,056
  • Requests with 200 status code: 190,119
  • P99 latency: 0.173462822

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,056 1,662
200 190,119 299,132
P99 0.173462822 0.070621091

Copy link
Member

@eldadfux eldadfux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Google, but not thank you. PR approved.

@eldadfux eldadfux merged commit 0ab86f4 into 1.6.x Dec 30, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy