-
Notifications
You must be signed in to change notification settings - Fork 4.4k
refactor-user-tokens #922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eldadfux
merged 12 commits into
appwrite:0.8.x
from
TorstenDittmann:refactor-user-tokens
Mar 29, 2021
Merged
refactor-user-tokens #922
eldadfux
merged 12 commits into
appwrite:0.8.x
from
TorstenDittmann:refactor-user-tokens
Mar 29, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldadfux
reviewed
Mar 29, 2021
@eldadfux checked all the stuff, ready for review 🙂 |
eldadfux
approved these changes
Mar 29, 2021
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes login sessions from the Tokens collection and uses a new dedicated collection called Sessions for authentication tokens. It also decouples OAuth2 references from the User document and moves them to Sessions This will allow us in the future to easily extend the authentication with more providers.
Collections
email
,anonymous
or any other OAuth2 provider)Migration
Invalidate all Login Tokens, since they can't be migrated to the new structure. Reason for it is the missing distinction between E-Mail and OAuth2 tokens.
Also migrates every collection change.
Test Plan
Utilizes already present tests and added new test to check for duplicate collection rules.
Related PRs and Issues
none
Have you read the Contributing Guidelines on issues?
✅