Skip to content

fix: amazon oauth #9253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: amazon oauth #9253

merged 1 commit into from
Jan 23, 2025

Conversation

ChiragAgg5k
Copy link
Member

What does this PR do?

Fixes Amazon OAuth.

Problem? Amazon for some reason was not returning the encoded state.
Solution: Encode the state using urlencode.

Test Plan

working:
Screenshot 2025-01-21 at 5 56 03 PM

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3 3.12.7-r0 CVE-2024-12254 HIGH
python3-pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3-pycache-pyc0 3.12.7-r0 CVE-2024-12254 HIGH
rsync 3.3.0-r0 CVE-2024-12084 CRITICAL
rsync 3.3.0-r0 CVE-2024-12085 HIGH
golang.org/x/crypto v0.26.0 CVE-2024-45337 CRITICAL
golang.org/x/net v0.28.0 CVE-2024-45338 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link

✨ Benchmark results

  • Requests per second: 1,033
  • Requests with 200 status code: 185,925
  • P99 latency: 0.174953628

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,033 1,689
200 185,925 304,048
P99 0.174953628 0.069008625

@ChiragAgg5k ChiragAgg5k changed the title fix: encoding state fix: amazon oauth Jan 21, 2025
@christyjacob4 christyjacob4 merged commit 85539df into 1.6.x Jan 23, 2025
63 checks passed
@christyjacob4 christyjacob4 deleted the fix-amazon-oauth branch January 23, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy