Move rule creation to create rule #9352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Meldiron merged 18 commits into feat-sites from feat-all-rules-in-proxy

Feb 18, 2025

Member

vermakhushboo commented Feb 12, 2025 •

edited

Loading

What does this PR do?

Instead of creating site and function rules in createSite and createFunction endpoints, we now create these rules from createRule endpoint in proxy
Moves createRule endpoint to module structure
Add updateRule endpoint

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

(Related PR or issue)

Checklist

Have you read the Contributing Guidelines on issues?
If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

vermakhushboo added 2 commits

February 12, 2025 23:58


          Move create rule to module

f416e39


          Resolve merge conflicts

f678709

github-actions bot commented Feb 12, 2025 •

edited

Loading

Security Scan Results for PR

Docker Image Scan Results

Package	Version	Vulnerability	Severity
libcrypto3	3.3.2-r1	CVE-2024-12797	HIGH
libssl3	3.3.2-r1	CVE-2024-12797	HIGH
openssl	3.3.2-r1	CVE-2024-12797	HIGH
openssl-dev	3.3.2-r1	CVE-2024-12797	HIGH
pyc	3.12.7-r0	CVE-2024-12254	HIGH
pyc	3.12.7-r0	CVE-2024-9287	HIGH
python3	3.12.7-r0	CVE-2024-12254	HIGH
python3	3.12.7-r0	CVE-2024-9287	HIGH
python3-pyc	3.12.7-r0	CVE-2024-12254	HIGH
python3-pyc	3.12.7-r0	CVE-2024-9287	HIGH
python3-pycache-pyc0	3.12.7-r0	CVE-2024-12254	HIGH
python3-pycache-pyc0	3.12.7-r0	CVE-2024-9287	HIGH
rsync	3.3.0-r0	CVE-2024-12084	CRITICAL
rsync	3.3.0-r0	CVE-2024-12085	HIGH
golang.org/x/crypto	v0.26.0	CVE-2024-45337	CRITICAL
golang.org/x/net	v0.28.0	CVE-2024-45338	HIGH

Source Code Scan Results

🎉 No vulnerabilities found!


          Create site rule

f9ce932

vermakhushboo requested a review from Meldiron

February 12, 2025 18:42


          Create rule in function logging test

4b909ed

github-actions bot commented Feb 12, 2025 •

edited

Loading

✨ Benchmark results

Requests per second: 828
Requests with 200 status code: 149,111
P99 latency: 0.226005575

⚡ Benchmark Comparison

Metric	This PR	Latest version
RPS	828	1,619
200	149,111	291,488
P99	0.226005575	0.071390706

vermakhushboo added 3 commits

February 13, 2025 14:21


          Remove older test

bd58ba3


          Merge branch 'feat-sites' into feat-all-rules-in-proxy

e87fe74


          Fix general tests

3531d22

Meldiron reviewed

View reviewed changes

src/Appwrite/Platform/Modules/Proxy/Http/Rules/Create.php Outdated Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

src/Appwrite/Platform/Modules/Proxy/Http/Rules/Create.php Outdated Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

src/Appwrite/Platform/Modules/Proxy/Http/Rules/Create.php Outdated Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

src/Appwrite/Platform/Modules/Proxy/Http/Rules/Create.php Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

src/Appwrite/Platform/Modules/Proxy/Http/Rules/Create.php Outdated Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

src/Appwrite/Platform/Modules/Sites/Http/Sites/Create.php Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

tests/e2e/General/UsageTest.php Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

tests/e2e/Services/Functions/FunctionsCustomServerTest.php Outdated Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

tests/e2e/Services/Projects/ProjectsCustomServerTest.php Outdated Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

tests/e2e/Services/Sites/SitesBase.php Outdated Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

tests/e2e/Services/Sites/SitesCustomServerTest.php Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

tests/e2e/Services/Functions/FunctionsCustomServerTest.php Outdated Show resolved Hide resolved

vermakhushboo and others added 7 commits

February 15, 2025 23:23


          Add helper methods in functionBase

b1854fe


          Merge branch 'feat-sites' into feat-all-rules-in-proxy

2f2a743


          Todos

30cb7e8


          Re-add correct project tests

9459c87


          Make switch case simpler

71103b0


          Fix new site tests

28ef7da


          Fix domain generation

2ea18c4

Meldiron reviewed

View reviewed changes

tests/e2e/General/UsageTest.php Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

tests/e2e/Services/Functions/FunctionsCustomServerTest.php Outdated Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

tests/e2e/Services/Projects/ProjectsCustomServerTest.php Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

tests/e2e/Services/Sites/SitesBase.php Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

tests/e2e/Services/Sites/SitesBase.php Outdated Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

tests/e2e/Services/Sites/SitesCustomServerTest.php Outdated Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

src/Appwrite/Platform/Modules/Proxy/Http/Rules/Create.php Outdated Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

src/Appwrite/Platform/Modules/Proxy/Http/Rules/Create.php Outdated Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

src/Appwrite/Platform/Modules/Proxy/Http/Rules/Create.php Outdated Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

src/Appwrite/Platform/Modules/Proxy/Http/Rules/Create.php Show resolved Hide resolved

Meldiron reviewed

View reviewed changes

src/Appwrite/Platform/Modules/Proxy/Http/Rules/Create.php Show resolved Hide resolved

Meldiron and others added 4 commits

February 17, 2025 15:05


          Fix CORS

2e4a8de


          Add more rule tests

262b152


          Fix site tests

c24cebf


          Fix site tests

db8010f

Meldiron approved these changes

View reviewed changes

Meldiron merged commit 3b87b42 into feat-sites

65 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy