Skip to content

Feat: Enhance rules #9395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Feb 25, 2025
Merged

Feat: Enhance rules #9395

merged 18 commits into from
Feb 25, 2025

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Feb 22, 2025 •
edited
Loading

What does this PR do?

  • Deny apex domains for non-NS setup
  • Add variable for Console to understood when apex domains are allowed
  • Remove createRule in favour of separation (createAPIRule, create FunctionRule, createSiteRule)
  • add createRedirectRule
  • add domain VCS automation (branch) to createSiteRule and createFunctionRule
  • Auto-generate per-branch and per-commit preview domains
  • Overhaul domains collection to simplicity (type=api/proxy/redirect, value=url/deploymentId/empty, automation="branch=dev"

Test Plan

  • Setup base proxy (rules) tests
  • More proxy rules tests
  • More more more more tests for all changes

Related PRs and Issues

x

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 22, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libcrypto3 3.3.2-r1 CVE-2024-12797 HIGH
libecpg 16.5-r0 CVE-2025-1094 HIGH
libecpg-dev 16.5-r0 CVE-2025-1094 HIGH
libpq 16.5-r0 CVE-2025-1094 HIGH
libpq-dev 16.5-r0 CVE-2025-1094 HIGH
libssl3 3.3.2-r1 CVE-2024-12797 HIGH
openssl 3.3.2-r1 CVE-2024-12797 HIGH
openssl-dev 3.3.2-r1 CVE-2024-12797 HIGH
postgresql16-dev 16.5-r0 CVE-2025-1094 HIGH
pyc 3.12.7-r0 CVE-2024-12254 HIGH
pyc 3.12.7-r0 CVE-2024-9287 HIGH
python3 3.12.7-r0 CVE-2024-12254 HIGH
python3 3.12.7-r0 CVE-2024-9287 HIGH
python3-pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3-pyc 3.12.7-r0 CVE-2024-9287 HIGH
python3-pycache-pyc0 3.12.7-r0 CVE-2024-12254 HIGH
python3-pycache-pyc0 3.12.7-r0 CVE-2024-9287 HIGH
rsync 3.3.0-r0 CVE-2024-12084 CRITICAL
rsync 3.3.0-r0 CVE-2024-12085 HIGH
golang.org/x/crypto v0.26.0 CVE-2024-45337 CRITICAL
golang.org/x/net v0.28.0 CVE-2024-45338 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 22, 2025 •
edited
Loading

✨ Benchmark results

  • Requests per second: 895
  • Requests with 200 status code: 161,215
  • P99 latency: 0.21350703

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 895 1,637
200 161,215 294,682
P99 0.21350703 0.070458214

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 24, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/appwrite/appwrite/@appwrite.io/console@9395

commit: 859a9c7

@Meldiron Meldiron mentioned this pull request Feb 24, 2025
Closed
3 tasks
vermakhushboo
vermakhushboo reviewed Feb 24, 2025
View reviewed changes
vermakhushboo
vermakhushboo reviewed Feb 24, 2025
View reviewed changes
app/controllers/general.php
->setContext('function', $resource);
$queueForEvents
->setParam('siteId', $resource->getId())
->setParam('executionId', $execution->getId())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sites have executionId?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions have the same piece of code. Yes, site's logs are in execution collection, exactly same as functions

vermakhushboo
vermakhushboo reviewed Feb 24, 2025
View reviewed changes
@Meldiron Meldiron marked this pull request as ready for review February 24, 2025 17:44
TorstenDittmann
TorstenDittmann reviewed Feb 25, 2025
View reviewed changes
vermakhushboo
vermakhushboo reviewed Feb 25, 2025
View reviewed changes
vermakhushboo
vermakhushboo reviewed Feb 25, 2025
View reviewed changes
vermakhushboo
vermakhushboo reviewed Feb 25, 2025
View reviewed changes
@Meldiron @vermakhushboo
Update src/Appwrite/Utopia/Response/Model/Rule.php
88b3791 
Co-authored-by: Khushboo Verma <43381712+vermakhushboo@users.noreply.github.com>
@Meldiron Meldiron merged commit ac9ac3e into feat-sites Feb 25, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann left review comments

@vermakhushboo vermakhushboo vermakhushboo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Meldiron @TorstenDittmann @vermakhushboo
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy