Skip to content

Chore debug tests #9730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: 1.7.x-migration
Choose a base branch
from
Open

Chore debug tests #9730

wants to merge 9 commits into from

Conversation

vermakhushboo
Copy link
Member

@vermakhushboo vermakhushboo commented May 6, 2025

What does this PR do?

Fix failing tests on cloud because of httpAlias issue

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Summary by CodeRabbit

  • Tests
    • Updated test cases to reflect changes in the API endpoint and request payload for updating function deployments. PATCH requests now use a revised endpoint and include the deployment ID in the request body instead of the URL path. Assertions and validation steps remain unchanged.
  • Chores
    • Updated service images for improved stability and performance in the console and runtime executor components.

Copy link

coderabbitai bot commented May 6, 2025

## Walkthrough

The changes update test methods across multiple end-to-end test files to reflect a new API endpoint and payload structure for updating function deployments. The PATCH request now targets `/functions/{functionId}/deployment` (singular) and includes the `deploymentId` in the request body instead of the URL path. Assertions and headers remain unchanged. Additionally, two service images in the docker-compose configuration were updated to newer versions.

## Changes

| Files                                                                                      | Change Summary                                                                                   |
|--------------------------------------------------------------------------------------------|--------------------------------------------------------------------------------------------------|
| tests/e2e/Services/Functions/FunctionsCustomServerTest.php                                 | Updated `testUpdateDeployment` to use new PATCH endpoint `/functions/{functionId}/deployment` and send `deploymentId` in the request body. |
| tests/e2e/Services/Realtime/RealtimeCustomClientTest.php                                   | Modified PATCH request in `testChannelExecutions` to use the new endpoint and payload with `deploymentId` in the body.                   |
| tests/e2e/Services/Webhooks/WebhooksCustomServerTest.php                                   | Changed `testUpdateDeployment` to PATCH `/functions/{id}/deployment` and include `deploymentId` in the body instead of the URL.           |
| docker-compose.yml                                                                         | Updated service images: `appwrite-console` from version `5.3.0-sites-rc.42` to `5.3.0-sites-rc.43`, and `openruntimes-executor` from `0.7.13` to `0.7.14`. |

## Sequence Diagram(s)

```mermaid
sequenceDiagram
    participant TestCase
    participant API
    TestCase->>API: PATCH /functions/{functionId}/deployment\n{ deploymentId }
    API-->>TestCase: 200 OK, { deploymentId, timestamps, ... }

Poem

A PATCH to the path, a tweak in the flow,
Deployment IDs now in the body go!
Singular endpoints, requests anew—
The tests all hop where the carrots grew.
With headers unchanged and checks still tight,
This bunny’s proud: the tests hop right! 🥕


<!-- walkthrough_end -->


---

<details>
<summary>📜 Recent review details</summary>

**Configuration used: .coderabbit.yaml**
**Review profile: CHILL**
**Plan: Pro**

<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between 36fa28cced86c8d3dbc423aa60ed690aad630739 and 91c007577704e8be1d0a30bbb3b3d797a97222f5.

</details>

<details>
<summary>⛔ Files ignored due to path filters (1)</summary>

* `composer.lock` is excluded by `!**/*.lock`

</details>

<details>
<summary>📒 Files selected for processing (1)</summary>

* `docker-compose.yml` (2 hunks)

</details>

<details>
<summary>✅ Files skipped from review due to trivial changes (1)</summary>

* docker-compose.yml

</details>

<details>
<summary>⏰ Context from checks skipped due to timeout of 90000ms (15)</summary>

* GitHub Check: Benchmark
* GitHub Check: E2E Service Test (Teams)
* GitHub Check: E2E Service Test (Locale)
* GitHub Check: E2E Service Test (Webhooks)
* GitHub Check: E2E Service Test (Messaging)
* GitHub Check: E2E Service Test (GraphQL)
* GitHub Check: E2E Service Test (Storage)
* GitHub Check: E2E Service Test (Proxy)
* GitHub Check: E2E Service Test (Sites)
* GitHub Check: E2E Service Test (FunctionsSchedule)
* GitHub Check: E2E Service Test (Realtime)
* GitHub Check: E2E Service Test (Databases)
* GitHub Check: E2E Service Test (Functions)
* GitHub Check: E2E Service Test (Account)
* GitHub Check: E2E General Test

</details>

</details>
<!-- internal state start -->


<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKNwSPbABsvkCiQBHbGlcSHFcLzpIACIAYVh8f0glAWwiMJDEaMgAdzRkBwFmdRp6OTDYD2xESkgpCmY0AGtYatgBfHx0ZFtIDEcBWoBOAHYAZgAGfixcSsgAQW5uHIp1D39ufER1RNkNGDnG+CxubApNmv4AMwrUXtQCSCv4AA8n7S9j9JpEXGR8GZzBhefDYehkCTwCgAtgYUIMNDVKLlTAoRAOdYkLzUKKPAAGsFwuG480++Tx+3cyWkDFW3HEAJQGFo8ARPwq1AqHgYsEwpHQ8GYyEe/kQ+C8Ui5lx+oSuHzO0gANJBUqEMF00LQWQyMGhfILuJFYbhqPBGUoTfAvP8+EwlIxeRhSMhnB5ePhIUp6McufZHI0XJTKklUOr7NxRPBngwMr8eNisIk/FicfRbC7mWiMchjWbyLQg9zKgwmp848dgWCoj7Zh4lIhafB6Xnk8VmcgmHDVqrEsKuldxSCcgou/BVV9IERsPAlJ9yBn6NhuLQcQsrABJSBsE0rk3oTO0fAMRzsU2MqPoJafBECSKF6x2VBoBgMaTbW8eTmE4mIDgAej/Ih1FaAQNCYZg/zQJYVjWSDoNWGg/1OHw/1GSYNCMfRjHAKAyHofAbkRAhiDIZRSgUVh2C4Xh+GEURxCkGR5DtZRVHULQdCwkwoDgVAnywIjCFIcgqHI8DjS4KhhwcJwXBVZjFFYtRNG0XQwEMbDTAMGVED/EgACYSD/ABlShIVfXSADFsAwMQ8ysmy7IBRBYmqAhmFMih6mgEING4WBuA4AxohCgwLAWdcSJE1M/Vk+QCIdPlpDcOYZS3EhZkUSA8RlABVZccQAERIQ18FkY08VyfIt0UKN4FxLoeSS315g3SA8M2Y5Qkweh/CCEIeDQWQQU1J4kyXXcJzQalSvK9h9isfxIVBRAvFkZVa1jUIajhdBrHmaBYgACWTfq43xP8rkcnVdIAbyu2ydXXWgAF8/yUWbjTuj6QTmuFnpeyqcmAvoug6Wh5G4Zw0G3ShEHvCaYrSnbaGFOYrAO47TuCc6ujxS7rvsv97sJgEAfekrfoqyAAAptidbxnBiH6yuNbJjl+EhRoSw0zj1ZnKdZ9gslyEGWb+3BnqZX0odmABKfdvVsrwqzRjw8XF41nsqms5j6nHQnB+RqumgApYyAHkADlBqoWGKHvSpNTh1ttEBDxEBhkhlR6318hqCgbumX1RU2DBLl+ahqgUJRlV4aQyFfa5fU19hIHXQqfczCQ9RnM9ExuWkuZ1RXIERmgwkFEIYe4ZB/COLBHMdUgCwODw0r1MVugDv4OVCTb/FwM582y1P/toSrGlwHlpF9AEPbT3XMTOw3FD2IxzEsUkaFE+ywi6TalGBaGg4SkgXk2QOoiTU5b1Zdq4XUerEEwyAAFkMoSehtiIXUh6ScudAuB4lvteJ4pMZghHyruEgxVPrsBpgAEl3GgOWXBnBUFkDrLAx90TZWso9eyrlfgsE8t5EI2Dso6T0oZEyZlWTSD/AQpy4cmEQJcm5UhZlKA+V+H5AKlUaZNSdFEfWA0Or4C6qXKGw18CjV+BQbAYgFRMm2PaTa24v5y2CqFAwEAwBGGoQZIyZCGG6RsFzLw4g2B/gsXqaxJBiHuViJ8dgvDND+UCjo6IYUt6RWEmRKIMkAzxULs3ZKBgqRpU0VlHKIR4iYHIF4AAoi8UQeB7JA2qswWqzxqzu0gEdaA0ArD7UOidMR51eShEAS6cBhDzSCwlveSpoRco2AADJVQ7OE+gVxoTMGygTBprCSYjPJmPP4xNJkA0qhdB6LC7oLKeq9Cm8C4QUgWFqJ+AI9RrQ2nrQIBsVRr26YlERfSBn7naswekxsKCYP3kySs9pppNBIPIPEAByGZtAvlAxBofJpxp06FW6CgXuOcVYkEdlzJQFA64kAbr6T2bBlQVhViyJ0I4aC7VwLICMcdoQiDEKCrO9BWqbneXsNu3dKBBwHD4fAwNsUDyOQNeubsy62V6cqeoUZZBTUgPpCYUxI5Dw7IpUu011QYDAEiu5M0qZpwztLNliAw6XCNhhXxCwrFkT3o8IFx9d7OWTufS+5Eb7YDvjGdgT8IlQCto1cJfYU6iGxKa8O/A+A/z/gqf4NwLWJCtXwUB997XiFnjkSgHhGhKHvDklk0Z85okgJ8Yo5EjVzC6pQXUvgQRARjAlTacTfgJIwEk1J6SbqT0/llYGswl7ZTsVYquTiWAuPqnCdxlVcHw28ZhLSRjaGmIsn+AA6iQAQCR8BNF0lOmdnR50do8twig7j+FeJCj48K8x/GkVEkE/0zhQnnOdClduA0Yn0DLbgaBRVgXsCyTmXJ9V6CPGEfyTalKH60E6rtfpLAhnLKJrdGcb1JnfSfePQGTz8agecsTCDazlUbP2LERIocARYqIPs30GNynYwGmGEEIi+AYtVu69ZoRVXNvaV02WsAVR4FUTQUaUN0Sz3UOC6aUM7YZVqM21pJyIbcvhb6al2Ufkwcln8zZVIRNO3hYi5FTckqtypP7ele9GTqs1R7E0EqY6fkzEbV2zbUXe3BYeFFNqaj9V2jGpdc66i50moyTmtd9jOv4LWPghb75Jk7LgaEvgrhDnPdG2NTJQuKCUXQHVm89U73zm641nq0vmoviG6+YabVgMjc/V+H9Mrf3gL/KOACeUaeAeGmMiHIG/AfTQOBaHcBIJQWg9ADyhqUP7dlRds6V2cLXV5HhFDpZ3t0sYuhXkzGTuncNhdS3l0cJIWN8hfDPF4kHXorSh4SyUDAOBC4MLypeCCju3V+6oqBO/ieuSCUv0RKpId95FATssDOyOZ4U4vVlwKuyXAOQugB3Mh4QUaBnRPPIDGvg9RtjOXvHiKCywEIkC++HcUJBKrg4YSgRo/JUCAMucB1H8FYKdjFJEDgABWDQYwNATDANsH4YAKAMA0AAFn0nMvGaOYKIWpzj+njPmes7WIgDnXPudjAU3MPE+AIwYEUY/Ng0vz41sSHj+hScofE+QKTp4Vylcq7Vw4mbaTjwEAoBwCYGgRgaAAIzy/g8rsgFuq5W+13bh3Tvnfc82b5/A/nfsVb5jqZUEIoQwjTjnVYKhIiID5eKE8KefV9AyqDigTR7AZXEE6F0SQXt9KTLWCOevZ5JixDUHIwZIcFOeHeDeN39VevS3MI+mXT5Bpy1ffC+XbUP3CMVvRkAWvViJ+3aHY1fVV+yoLjHWOae45N+TpfVPnKi4Z0zlnbPpAy553z+Dm/hfb9p7viXB/pec5527n0Gsjwfa+7crY53mBeApOPyf3pp9hFnwHHn3myTjN09xskt3lWtzwB13X0GTANVwgO9z0mgNt3t0dxdzd3xA90QPV0YS1xt0SHQIDyDym3e2O1O3fw0Au2/2u32w0m4j/WTkEjuyPXoHEioj8DQGkke3kHKBYioDYhUk4nUgMEYPEnUAAH0ZxEBJClp6oY1aBJDI5A41IGCcJIAxgAA2OUfSAADhfDoD0K0IYD0NoDGFoAEAYF5zGDQDQC0ImDoC0KGAmDsNoC0MmHGCGDULEI0KGGdwYFFRGDpxGFCImG5xID0MGGd1oFcMmFUAEDGESNoBGFGDQFGH0kyKuDpx8N8IgAokzWkNRjkJIEhBIEUMkLwjUKAA= -->

<!-- internal state end -->
<!-- tips_start -->

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

<details>
<summary>❤️ Share</summary>

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)
- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)
- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)
- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

</details>

<details>
<summary>🪧 Tips</summary>

### Chat

There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=appwrite/appwrite&utm_content=9730):

- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  - `I pushed a fix in commit <commit_id>, please review it.`
  - `Generate unit testing code for this file.`
  - `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
  - `@coderabbitai generate unit testing code for this file.`
  -	`@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.`
  - `@coderabbitai read src/utils.ts and generate unit testing code.`
  - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`
  - `@coderabbitai help me debug CodeRabbit configuration file.`

### Support

Need help? Create a ticket on our [support page](https://www.coderabbit.ai/contact-us/support) for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

### CodeRabbit Commands (Invoked using PR comments)

- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai full review` to do a full review from scratch and review all the files again.
- `@coderabbitai summary` to regenerate the summary of the PR.
- `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR.
- `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository.
- `@coderabbitai help` to get help.

### Other keywords and placeholders

- Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.
- Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description.
- Add `@coderabbitai` anywhere in the PR title to generate the title automatically.

### Documentation and Community

- Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

</details>

<!-- tips_end -->

@vermakhushboo vermakhushboo requested a review from Meldiron May 6, 2025 19:25
Copy link

github-actions bot commented May 6, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.42-r0 CVE-2025-0840 HIGH
libexpat 2.6.4-r0 CVE-2024-8176 HIGH
libxml2 2.12.7-r0 CVE-2024-56171 HIGH
libxml2 2.12.7-r0 CVE-2025-24928 HIGH
libxml2 2.12.7-r0 CVE-2025-27113 HIGH
sqlite-libs 3.45.3-r1 CVE-2025-29087 HIGH
xz 5.6.2-r0 CVE-2025-31115 HIGH
xz-libs 5.6.2-r0 CVE-2025-31115 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link

github-actions bot commented May 6, 2025

✨ Benchmark results

  • Requests per second: 965
  • Requests with 200 status code: 173,683
  • P99 latency: 0.194185347

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 965 1,370
200 173,683 246,640
P99 0.194185347 0.134524327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy