-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Chore debug tests #9730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vermakhushboo
wants to merge
9
commits into
1.7.x-migration
Choose a base branch
from
chore-debug-tests
base: 1.7.x-migration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Chore debug tests #9730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Walkthrough
The changes update test methods across multiple end-to-end test files to reflect a new API endpoint and payload structure for updating function deployments. The PATCH request now targets `/functions/{functionId}/deployment` (singular) and includes the `deploymentId` in the request body instead of the URL path. Assertions and headers remain unchanged. Additionally, two service images in the docker-compose configuration were updated to newer versions.
## Changes
| Files | Change Summary |
|--------------------------------------------------------------------------------------------|--------------------------------------------------------------------------------------------------|
| tests/e2e/Services/Functions/FunctionsCustomServerTest.php | Updated `testUpdateDeployment` to use new PATCH endpoint `/functions/{functionId}/deployment` and send `deploymentId` in the request body. |
| tests/e2e/Services/Realtime/RealtimeCustomClientTest.php | Modified PATCH request in `testChannelExecutions` to use the new endpoint and payload with `deploymentId` in the body. |
| tests/e2e/Services/Webhooks/WebhooksCustomServerTest.php | Changed `testUpdateDeployment` to PATCH `/functions/{id}/deployment` and include `deploymentId` in the body instead of the URL. |
| docker-compose.yml | Updated service images: `appwrite-console` from version `5.3.0-sites-rc.42` to `5.3.0-sites-rc.43`, and `openruntimes-executor` from `0.7.13` to `0.7.14`. |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant TestCase
participant API
TestCase->>API: PATCH /functions/{functionId}/deployment\n{ deploymentId }
API-->>TestCase: 200 OK, { deploymentId, timestamps, ... } Poem
|
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
✨ Benchmark results
⚡ Benchmark Comparison
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix failing tests on cloud because of
httpAlias
issueTest Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist
Summary by CodeRabbit