fix: task coroutine hooks #9814

basert · 2025-05-19T10:42:02Z

Needed until we have #9757

Summary by CodeRabbit

Chores
- Enabled coroutine support in the CLI application environment. This prepares the app for improved performance in future updates. No visible changes to CLI commands or outputs.

coderabbitai · 2025-05-19T10:42:10Z

Walkthrough

The update imports the Swoole\Runtime class and enables Swoole coroutine support with TCP hooks disabled in the CLI entry point. A comment clarifies that TCP hooks will not function until specific pool adapters are used. No other changes were made to the CLI execution flow or public interfaces.

Changes

File(s)	Change Summary
app/cli.php	Imported `Swoole\Runtime`, enabled coroutine support with TCP hooks disabled, and added a comment about TCP hooks usage.

Poem

In the code where coroutines now awake,
Swoole’s magic stirs, but hooks don’t partake.
Awaiting the pools to join the dance,
The CLI stands ready, given the chance.
With a hop and a skip, the runtime’s set—
More async adventures may come yet!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 65fd12d and 3274a38.

📒 Files selected for processing (1)

app/cli.php (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

app/cli.php

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Setup & Build Appwrite Image
GitHub Check: Setup & Build Appwrite Image
GitHub Check: scan

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

app/cli.php (1)
302-304: Guard coroutine initialization for non-Swoole environments.
Directly calling Runtime::enableCoroutine(true, 0) and run(...) will trigger a fatal error if the Swoole extension is missing. Consider wrapping these calls in a check, for example:
+ if (extension_loaded('swoole') && class_exists(\Swoole\Runtime::class)) {
     // Enable coroutines, but disable hooks. These don't work until we use `\Utopia\Cache\Adapter\Pool` and `\Utopia\Database\Adapter\Pool`.
     Runtime::enableCoroutine(true, 0);
     run($cli->run(...));
+ } else {
+     // Fallback to synchronous execution if Swoole is unavailable
+     $cli->run(...);
+ }
This ensures compatibility in environments without Swoole installed.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 0ec7ff2 and 65fd12d.

📒 Files selected for processing (1)

app/cli.php (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Setup & Build Appwrite Image
GitHub Check: Setup & Build Appwrite Image
GitHub Check: scan

🔇 Additional comments (1)

app/cli.php (1)

13-13: Correct import of Swoole\Runtime.
Importing Runtime is necessary for invoking enableCoroutine. This aligns with the new coroutine setup and will prevent undefined class errors.

github-actions · 2025-05-19T10:44:16Z

Security Scan Results for PR

Docker Image Scan Results

Package	Version	Vulnerability	Severity
binutils	2.42-r0	CVE-2025-0840	HIGH
libexpat	2.6.4-r0	CVE-2024-8176	HIGH
libxml2	2.12.7-r0	CVE-2024-56171	HIGH
libxml2	2.12.7-r0	CVE-2025-24928	HIGH
libxml2	2.12.7-r0	CVE-2025-27113	HIGH
libxml2	2.12.7-r0	CVE-2025-32414	HIGH
libxml2	2.12.7-r0	CVE-2025-32415	HIGH
sqlite-libs	3.45.3-r1	CVE-2025-29087	HIGH
xz	5.6.2-r0	CVE-2025-31115	HIGH
xz-libs	5.6.2-r0	CVE-2025-31115	HIGH
golang.org/x/crypto	v0.31.0	CVE-2025-22869	HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

github-actions · 2025-05-19T10:55:06Z

✨ Benchmark results

Requests per second: 924
Requests with 200 status code: 166,285
P99 latency: 0.211950031

⚡ Benchmark Comparison

Metric	This PR	Latest version
RPS	924	1,242
200	166,285	223,600
P99	0.211950031	0.149470777

coderabbitai bot reviewed May 19, 2025

View reviewed changes

fix: task coroutine hooks

3274a38

basert force-pushed the task-coroutine-hooks branch from 65fd12d to 3274a38 Compare May 19, 2025 12:02

christyjacob4 approved these changes May 19, 2025

View reviewed changes

christyjacob4 merged commit 24312e6 into main May 19, 2025
38 checks passed

christyjacob4 deleted the task-coroutine-hooks branch May 19, 2025 12:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: task coroutine hooks #9814

fix: task coroutine hooks #9814

Uh oh!

basert commented May 19, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented May 19, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

github-actions bot commented May 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

fix: task coroutine hooks #9814

fix: task coroutine hooks #9814

Uh oh!

Conversation

basert commented May 19, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Security Scan Results for PR

Docker Image Scan Results

Source Code Scan Results

Uh oh!

github-actions bot commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Benchmark results

⚡ Benchmark Comparison

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

basert commented May 19, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 19, 2025 •

edited

Loading

github-actions bot commented May 19, 2025 •

edited

Loading

github-actions bot commented May 19, 2025 •

edited

Loading