Skip to content

fix: send deploymentResourceType in rules verification #9859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

fix: send deploymentResourceType in rules verification #9859

merged 1 commit into from
May 22, 2025

Conversation

basert
Copy link
Contributor

@basert basert commented May 22, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features
    • Enhanced certificate issuance process to dynamically determine domain type based on rule attributes, improving accuracy and flexibility in certificate handling during domain verification updates.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 22, 2025 •
edited
Loading

Walkthrough

The changes update how the domainType attribute is set when queuing certificates for various domain-related rules. Instead of using a fixed string, the code now dynamically retrieves the domainType from the rule's deploymentResourceType attribute, defaulting to the type attribute if necessary. Additionally, the source of domainType in the certificate worker was changed from the root payload to the nested domain document. No changes to public interfaces were made.

Changes

File(s) Change Summary
app/controllers/api/proxy.php Modified to set domainType in the certificate queue from deploymentResourceType or fallback to type when updating verification.
src/Appwrite/Platform/Modules/Proxy/Http/Rules/API/Create.php Changed domainType from hardcoded 'api' to dynamic value from deploymentResourceType or type.
src/Appwrite/Platform/Modules/Proxy/Http/Rules/Function/Create.php Changed domainType from hardcoded 'function' to dynamic value from deploymentResourceType or type.
src/Appwrite/Platform/Modules/Proxy/Http/Rules/Redirect/Create.php Changed domainType from hardcoded 'redirect' to dynamic value from deploymentResourceType or type.
src/Appwrite/Platform/Modules/Proxy/Http/Rules/Site/Create.php Changed domainType from hardcoded 'site' to dynamic value from deploymentResourceType or type.
src/Appwrite/Platform/Workers/Certificates.php Changed domainType extraction in worker from root payload key to nested domain document attribute.

Poem

A rabbit hopped through lines of code,
Where "domainType" once firmly strode.
Now nimble, it looks and sees—
"deploymentResourceType" with ease!
If not, it falls back, no fright,
To trusty old "type" in the night.
Certificates queued, the future is bright! 🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between de5b8e3 and 128dc1d.

📒 Files selected for processing (6)
  • app/controllers/api/proxy.php (1 hunks)
  • src/Appwrite/Platform/Modules/Proxy/Http/Rules/API/Create.php (1 hunks)
  • src/Appwrite/Platform/Modules/Proxy/Http/Rules/Function/Create.php (1 hunks)
  • src/Appwrite/Platform/Modules/Proxy/Http/Rules/Redirect/Create.php (1 hunks)
  • src/Appwrite/Platform/Modules/Proxy/Http/Rules/Site/Create.php (1 hunks)
  • src/Appwrite/Platform/Workers/Certificates.php (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
  • app/controllers/api/proxy.php
  • src/Appwrite/Platform/Modules/Proxy/Http/Rules/Site/Create.php
  • src/Appwrite/Platform/Modules/Proxy/Http/Rules/Function/Create.php
  • src/Appwrite/Platform/Modules/Proxy/Http/Rules/Redirect/Create.php
  • src/Appwrite/Platform/Modules/Proxy/Http/Rules/API/Create.php
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Benchmark
  • GitHub Check: scan
🔇 Additional comments (1)
src/Appwrite/Platform/Workers/Certificates.php (1)

99-99: LGTM: Correctly updates domainType retrieval.

The change correctly updates how the domainType is retrieved, now sourcing it from the domain document attribute instead of directly from the root payload. This aligns with the other changes mentioned in the PR summary where domainType is dynamically derived from the rule's deploymentResourceType attribute.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.42-r0 CVE-2025-0840 HIGH
libexpat 2.6.4-r0 CVE-2024-8176 HIGH
libxml2 2.12.7-r0 CVE-2024-56171 HIGH
libxml2 2.12.7-r0 CVE-2025-24928 HIGH
libxml2 2.12.7-r0 CVE-2025-27113 HIGH
libxml2 2.12.7-r0 CVE-2025-32414 HIGH
libxml2 2.12.7-r0 CVE-2025-32415 HIGH
sqlite-libs 3.45.3-r1 CVE-2025-29087 HIGH
xz 5.6.2-r0 CVE-2025-31115 HIGH
xz-libs 5.6.2-r0 CVE-2025-31115 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@basert basert force-pushed the sites-certificates branch from de5b8e3 to 128dc1d Compare May 22, 2025 08:05
@github-actions GitHub Actions
Copy link

✨ Benchmark results

  • Requests per second: 981
  • Requests with 200 status code: 176,549
  • P99 latency: 0.189790998

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 981 1,161
200 176,549 208,964
P99 0.189790998 0.161408408

@christyjacob4 christyjacob4 merged commit 3c74818 into main May 22, 2025
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basert @christyjacob4
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy