Skip to content

fix(migration): _APP_DEFAULT_REGION is not a valid env var #9883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2025
Merged

fix(migration): _APP_DEFAULT_REGION is not a valid env var #9883

merged 1 commit into from
May 24, 2025
+2 −2

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented May 24, 2025 •
edited by coderabbitai bot
Loading

What does this PR do?

Across the rest of the codebase, we use _APP_REGION with 'default' as the fallback value. This commit updates the migration to do the same.

Test Plan

Manual

Related PRs and Issues

Related issue:

Previous attempt:

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Summary by CodeRabbit

  • Bug Fixes
    • Updated the logic for setting the "region" attribute in migrated rules to use the correct default region, improving consistency in region assignment during migration.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 24, 2025 •
edited
Loading

Walkthrough

The migration logic for the "rules" collection was updated to change how the "region" attribute is determined. The code now uses the _APP_REGION environment variable with a fallback to 'default', instead of _APP_DEFAULT_REGION, both when a project is found and when it is not.

Changes

File Change Summary
src/Appwrite/Migration/Version/V22.php Updated migration logic to set "region" using _APP_REGION with fallback 'default' instead of _APP_DEFAULT_REGION.

Sequence Diagram(s)

sequenceDiagram
    participant Migration
    participant RulesCollection
    participant Project

    Migration->>RulesCollection: Retrieve rule document
    Migration->>Project: Try to find associated project
    alt Project found
        Project-->>Migration: Return project with "region" attribute
        Migration->>RulesCollection: Set "region" from project or fallback to _APP_REGION/'default'
    else Project not found
        Migration->>RulesCollection: Set "region" from _APP_REGION or 'default'
    end
Loading

Possibly related PRs

Suggested reviewers

  • christyjacob4
  • TorstenDittmann

Poem

In the code fields where regions are set,
A rabbit hops, no regrets.
From _APP_REGION it takes its cue,
With 'default' as fallback, just for you.
The migration hops on, nimble and bright,
Setting regions just right!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 341bcb5 and 295e277.

📒 Files selected for processing (1)
  • src/Appwrite/Migration/Version/V22.php (1 hunks)
🔇 Additional comments (2)
src/Appwrite/Migration/Version/V22.php (2)

356-356: LGTM! Consistent environment variable usage when project is not found.

The change from _APP_DEFAULT_REGION to _APP_REGION with 'default' fallback aligns with the codebase conventions and ensures consistency across the migration.

360-360: LGTM! Consistent fallback logic when project is found.

The fallback logic now consistently uses _APP_REGION with 'default' value, matching the pattern used when the project is not found. This ensures uniform behavior throughout the migration process.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.42-r0 CVE-2025-0840 HIGH
libexpat 2.6.4-r0 CVE-2024-8176 HIGH
libxml2 2.12.7-r0 CVE-2024-56171 HIGH
libxml2 2.12.7-r0 CVE-2025-24928 HIGH
libxml2 2.12.7-r0 CVE-2025-27113 HIGH
libxml2 2.12.7-r0 CVE-2025-32414 HIGH
libxml2 2.12.7-r0 CVE-2025-32415 HIGH
sqlite-libs 3.45.3-r1 CVE-2025-29087 HIGH
xz 5.6.2-r0 CVE-2025-31115 HIGH
xz-libs 5.6.2-r0 CVE-2025-31115 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@stnguyen90
fix(migration): _APP_DEFAULT_REGION is not a valid env var
295e277 
Across the rest of the codebase, we use _APP_REGION with 'default' as
the fallback value. This commit updates the migration to do the same.
@stnguyen90 stnguyen90 force-pushed the fix-migration-default-region branch from d3ea873 to 295e277 Compare May 24, 2025 00:46
@github-actions GitHub Actions
Copy link

✨ Benchmark results

  • Requests per second: 933
  • Requests with 200 status code: 167,974
  • P99 latency: 0.199749141

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 933 1,150
200 167,974 207,128
P99 0.199749141 0.161616537

@stnguyen90 stnguyen90 marked this pull request as ready for review May 24, 2025 01:05
@stnguyen90 stnguyen90 moved this to Code Review in 1.7 Release May 24, 2025
@stnguyen90 stnguyen90 mentioned this pull request May 24, 2025
Merged
@stnguyen90 stnguyen90 merged commit 4c5094d into main May 24, 2025
38 checks passed
@github-project-automation github-project-automation bot moved this from Code Review to Done in 1.7 Release May 24, 2025
@stnguyen90 stnguyen90 deleted the fix-migration-default-region branch May 24, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
1.7 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stnguyen90 @TorstenDittmann
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy