Skip to content

[breaking] Refactor codebase to use a single Sketch struct #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 13, 2021
Merged

[breaking] Refactor codebase to use a single Sketch struct #1353

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d6d1653
Refactor codebase to use a single Sketch struct
silvanocerza Jul 8, 2021
2f2e2a6
Add back removed legacy test
silvanocerza Jul 12, 2021
db9c761
Changed Sketch struct to not use pointers
silvanocerza Jul 12, 2021
8de0dec
Fix small comment
silvanocerza Jul 12, 2021
7d00b83
Fix checkSketchCasing to work with .pde files too
silvanocerza Jul 12, 2021
ac517be
Add tests loading Sketch with symlinks
silvanocerza Jul 12, 2021
07f3ae5
Update UPGRADING.md
silvanocerza Jul 12, 2021
9cac5aa
Clarify a code comment
silvanocerza Jul 13, 2021
bf30333
Add some more tests for Sketches with symlinks
silvanocerza Jul 13, 2021
9618e9d
Fix Sketch symlinks tests for Windows
silvanocerza Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarify a code comment
  • Loading branch information
@silvanocerza
silvanocerza committed Jul 13, 2021
commit 9cac5aabd058a145b7bfe2a8a27adbba69476e84
2 changes: 1 addition & 1 deletion commands/instances.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,7 @@ func Upgrade(ctx context.Context, req *rpc.UpgradeRequest, downloadCB DownloadPr

// LoadSketch collects and returns all files composing a sketch
func LoadSketch(ctx context.Context, req *rpc.LoadSketchRequest) (*rpc.LoadSketchResponse, error) {
// TODO: This a ToRpc function for the Sketch struct
// TODO: This should be a ToRpc function for the Sketch struct
sketch, err := sk.New(paths.New(req.SketchPath))
if err != nil {
return nil, fmt.Errorf("error loading sketch %v: %v", req.SketchPath, err)
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy