Skip to content

Fix gRPC BoardList* methods concurrency issues #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 10, 2022
Merged

Fix gRPC BoardList* methods concurrency issues #1804

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1a5dfc5
Improved streaming of pluggable-discoveries events (WIP)
cmaglie Jul 13, 2022
dcf465e
Added discovery id in discovery.Event struct
cmaglie Jul 13, 2022
81dc23f
Cache active ports and transmit them when a new watcher connects
cmaglie Jul 13, 2022
599fd0c
Correctly handle discovery cleanup
cmaglie Jul 13, 2022
804726b
Fixed wrong test
cmaglie Jul 13, 2022
f638a97
Correctly handle discovery cleanup and re-add
cmaglie Jul 14, 2022
601c243
Added some doc comments in the source code
cmaglie Jul 20, 2022
081551b
Move Unlock under defer
cmaglie Jul 20, 2022
6c1c8df
Factored subrotuine into a function
cmaglie Aug 4, 2022
aeec293
Do not cache ports in the DiscoveryClient
cmaglie Aug 4, 2022
7f68a75
Discovery: eventChan must be protected by mutex when doing START_SYNC
cmaglie Aug 8, 2022
1f14c17
Increased error level for logging watchers that lags
cmaglie Aug 8, 2022
baf517d
Updated discvoery_client to the latest API
cmaglie Aug 8, 2022
7c6784e
Report discovery start errors
cmaglie Aug 8, 2022
4c197b8
Update arduino/discovery/discovery_client/main.go
cmaglie Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move Unlock under defer
  • Loading branch information
@cmaglie
cmaglie committed Aug 10, 2022
commit 081551b8d530d0ee35659e7cd2ad0dc8ce7a722f
2 changes: 1 addition & 1 deletion arduino/discovery/discoverymanager/discoverymanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,9 @@ func (dm *DiscoveryManager) Watch() (*PortWatcher, error) {
}
watcher.closeCB = func() {
dm.watchersMutex.Lock()
defer dm.watchersMutex.Unlock()
delete(dm.watchers, watcher)
close(watcher.feed)
dm.watchersMutex.Unlock()
}
go func() {
dm.watchersMutex.Lock()
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy