Skip to content

Allow falsey but non-None grant uri params #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion authlib/oauth2/rfc6749/parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def prepare_grant_uri(uri, client_id, response_type, redirect_uri=None,
params.append(('state', state))

for k in kwargs:
if kwargs[k]:
if kwargs[k] is not None:
params.append((to_unicode(k), kwargs[k]))

return add_params_to_uri(uri, params)
Expand Down
7 changes: 7 additions & 0 deletions tests/core/test_oauth2/test_rfc6749_misc.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,13 @@ def test_parse_implicit_response(self):
rv,
{'access_token': 'a', 'token_type': 'bearer', 'state': 'c'}
)

def test_prepare_grant_uri(self):
grant_uri = parameters.prepare_grant_uri('https://i.b/authorize', 'dev', 'code', max_age=0)
self.assertEqual(
grant_uri,
"https://i.b/authorize?response_type=code&client_id=dev&max_age=0"
)


class OAuth2UtilTest(unittest.TestCase):
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy