-
-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XDomainRequest support #140
Conversation
Closes #131 |
+1 |
@mzabriskie if the PR looks good can you have it merged? |
Good job! Any news on when this'll be merged? Looking to use it in a project without having to reference the commit hash. |
@mzabriskie can we have this merged? we are waiting to use this feature in our project. |
Sorry, I thought that I had replied to this already. A couple changes need to be made, but overall I like the solution.
// This would go at the top of lib/adapters/xhr.js
var isURLSameOrigin = require('./../helpers/isURLSameOrigin');
// Slight modification to your code
var adapter = (XMLHttpRequest || ActiveXObject);
var loadEvent = 'onreadystatechange';
var xDomain = false;
// For IE 8/9 CORS support
if (!isURLSameOrigin(config.url) && window.XDomainRequest) {
adapter = window.XDomainRequest;
loadEvent = 'onload';
xDomain = true;
} |
…estSupport Conflicts: lib/adapters/xhr.js
…into xDomainRequestSupport
There was a failing test on master when you merged. I have fixed the test. Please try merging master into your branch again. |
…estSupport Conflicts: package.json
Done! |
No description provided.