Clarify in README that default timeout is 0 (no timeout) #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 13, 2019
This was referenced Aug 29, 2019
This was referenced Sep 22, 2019
This was referenced Oct 16, 2019
This was referenced Oct 26, 2019
This was referenced Jan 9, 2020
This was referenced Apr 2, 2020
Closed
This was referenced Apr 13, 2020
This was referenced Apr 21, 2020
This was referenced Apr 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't make a GitHub issue since this is such a simple documentation update.
When I Cmd-F to find "timeout" in the README (i.e. GitHub home page for Axios), I see
timeout: 1000, but the default is actually0(no timeout). Similar to how other configs have their// defaultlisted in a comment, I added a comment to specify that even though the example says timeout is1000, the default is0(no timeout).This caused confusion in my project with an unreliable API. I couldn't find the source of a queue that was blocking too much, and after a few hours I realized that the Axios timeout is actually
0, not1000.