Fixes redirect behavior to correctly set host/port #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzabriskie
added a commit
that referenced
this pull request
Jan 19, 2016
Fixes redirect behavior to correctly set host /port
|
This fix is available in 0.9.1 |
|
Great, thanks 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently supply options to
follow-redirectsin the format{ host, port }, but the port is incorrectly dropped during redirect due to the way thaturl.formathandleshostvshostname. For the purposes ofhttp,hostandhostnameare aliases, but when building the redirect URL,hostis assumed to be the full origin. We should supplyhostnameinstead.I have added a test for this case. I you change the options to use
hostinstead ofhostname, the tests will hang as the request is being incorrectly redirected to "http://localhost/two" instead of "http://localhost:4444/two".