-
-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing custom config options #2207
Conversation
@jasonsaayman, here it is 👍 |
I hate to do so, but seeing you did the last release @emilyemorehouse could you give us your advice on this PR? The caching module axio README provides is not working as of axios 0.19. Thanks! |
When this can be merged? a lot of plugins have stopped working and waiting for this. |
When this will be merged? We would need to implement own solutions otherwise instead using plugins... |
@emilyemorehouse @nickuraltsev FWIW, as author of #1395 I'd approve this PR and merge it. As messy as it is to allow including any properties carried around in the axios config, it was the past behaviour and should definitely be restored. I was not aware of such functionality being relied upon by third-party plugins when making the original PR. |
Even if the breaking change stands, is there a strategy for plugins having custom config options to migrate to? |
Looking forward to see this resolved. It would fix: softonic/axios-retry#82 |
Is this going to be merged? |
@rafaelrenanpacheco, can you approve this pull request ? |
Is there any ETA on this? |
Anything we can do to get this into the master? |
Hey, I am a new maintainer for this project. I updated @emilyemorehouse about it. I see one conflict. I am happy to merge unless someone has a clear objection. There is a conflict right now that needs to be addressed |
@jphilipstevens all done! |
Can I merge this pull request? |
@rafaelrenanpacheco @felipewmartins as I see, the project does not use the merge strategy. |
|
@rafaelrenanpacheco rebase if you can :) |
This PR is a conflict fix of #2006 with some code style fix as well. The main work was done by @oleduc.