Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue for HEAD method and gziped repsonse #2666

Merged
merged 1 commit into from
Feb 15, 2020
Merged

Fixing issue for HEAD method and gziped repsonse #2666

merged 1 commit into from
Feb 15, 2020

Conversation

galkin
Copy link
Contributor

@galkin galkin commented Jan 15, 2020

This pull should fix #2665 and very similar to #1129

@chinesedfan
Copy link
Collaborator

@galkin Thanks for your fix and it looks good to me. Forgive that I am not an HTTP expert. I want to ask a question before approving. Does it mean HEAD requests will always have no content? At least, MDN says that.

@galkin
Copy link
Contributor Author

galkin commented Jan 27, 2020

@chinesedfan, yes, according to http specification HEAD requests always have not body, but headers should be equals to GET method.

@chinesedfan
Copy link
Collaborator

@galkin Would you mind updating the branch with the latest master? Looks like your PR is based your master branch, so I can't update it by myself.

@galkin
Copy link
Contributor Author

galkin commented Feb 15, 2020

@chinesedfan, done.

@chinesedfan
Copy link
Collaborator

@galkin Damn it. I just fixed a test bug, #2748. Can I beg you again?

@galkin
Copy link
Contributor Author

galkin commented Feb 15, 2020

@chinesedfan, done.

@chinesedfan chinesedfan changed the title Fixing issue for HEAD method and gziped repsonse #2665 Fixing issue for HEAD method and gziped repsonse Feb 15, 2020
@chinesedfan chinesedfan merged commit 12e00b8 into axios:master Feb 15, 2020
This was referenced Feb 15, 2020
Closed
Merged
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chinesedfan chinesedfan chinesedfan approved these changes

@rubennorte rubennorte Awaiting requested review from rubennorte

@emilyemorehouse emilyemorehouse Awaiting requested review from emilyemorehouse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Axios crashes on HEAD method and gziped repsonse
2 participants
@galkin @chinesedfan
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy