refactor: generalize serde logic into macro #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its the same as lowercase but removes the difference
its a bit easier to read when its imported from the same place
ayrat555
approved these changes
Sep 18, 2024
|
BTW @Veetaha thanks for the inspiration on this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines all the serde and builder settings for the API structs into a single macro.
serde_with::skip_serializing_noneallows removing all the#[serde(skip_serializing_if = "Option::is_none")].Doing something similar for the enums results in more lines before, so I just cleaned them up to use the same order of derives.
Nothing of this PR should be breaking.