Skip to content

Expose LogDiagnosticsState #19323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 23, 2025
Merged

Expose LogDiagnosticsState #19323

merged 9 commits into from
May 23, 2025

Conversation

hukasu
Copy link
Contributor

@hukasu hukasu commented May 21, 2025 •
edited
Loading

Objective

Closes #19175
Make LogDiagnosticsState public to be able to edit its filters

Solution

Make LogDiagnosticsState public and add methods to allow editing the duration and filter

Testing

cargo run -p ci

Showcase

Updated log_diagnostics example
image

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Diagnostics Logging, crash handling, error reporting and performance analysis S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 22, 2025
alice-i-cecile
alice-i-cecile reviewed May 22, 2025
View reviewed changes
alice-i-cecile
alice-i-cecile reviewed May 22, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable enough, but I'd be more comfortable merging this with a test verifying that this can be changed at runtime.

@hukasu
Copy link
Contributor Author

hukasu commented May 22, 2025

@alice-i-cecile updated the existing log_diagnostics example to have controls to enable/disable filtering

@hukasu
Copy link
Contributor Author

hukasu commented May 22, 2025

@benfrankel is this workable?

benfrankel
benfrankel approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@benfrankel benfrankel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because this resolves the linked issue. I skimmed the code but have not done an in-depth review.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 23, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 23, 2025
Merged via the queue into bevyengine:main with commit d3012df May 23, 2025
34 checks passed
@hukasu hukasu deleted the issue19175 branch May 23, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@benfrankel benfrankel benfrankel approved these changes

Assignees
No one assigned
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose LogDiagnosticsState
3 participants
@hukasu @alice-i-cecile @benfrankel
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy