feat(lint): add noDestructuredProps
#4983
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4983 will degrade performances by 6.4%Comparing Summary
Benchmarks breakdown
|
867145a to
2aa5b90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements https://github.com/solidjs-community/eslint-plugin-solid/blob/main/packages/eslint-plugin-solid/docs/no-destructure.md
Closes #4986
How it is implemented
To implement the rule, we query the destructure of props inside a JSX component, then we start iterating over the bindings using an ad-hoc iterator.
The iterator consists of a queue and a current list. We start iterating over the current list, and we return only the bindings we are interested in. If we find nested binding patterns, we add them to the queue.
Once the current list doesn't return any more bindings, we start popping an item from the queue. If there's another list, we mark it as "current list", and we start consuming bindings again.
The iterator is consumed once we don't have any more bindings and the queue is empty.
Compared to the original rule, this rule doesn't provide a code action.
Test Plan
Added test cases from the original rule