Skip to content

feat(ledger): Add Byron transaction output support to NewTransactionOutputFromCbor #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025

Conversation

arepala-uml
Copy link
Contributor

  1. Enabled support for decoding Byron transaction outputs in NewTransactionOutputFromCbor
  2. Uncommented Byron handling in DetermineTransactionType to detect Byron transactions
  3. Added test cases for DetermineTransactionType with valid Byron CBOR.

Closes #849

…saction output wrapper and type detection

Signed-off-by: Akhil Repala <arepala@blinklabs.io>
@arepala-uml arepala-uml marked this pull request as ready for review April 17, 2025 21:41
@arepala-uml arepala-uml requested a review from a team as a code owner April 17, 2025 21:41
Signed-off-by: Akhil Repala <arepala@blinklabs.io>
@arepala-uml arepala-uml requested a review from agaffney April 17, 2025 22:31
@wolf31o2 wolf31o2 merged commit 194a33b into main Apr 17, 2025
10 of 13 checks passed
@wolf31o2 wolf31o2 deleted the byron_transaction branch April 17, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Byron transaction output support to NewTransactionOutputFromCbor
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy