Skip to content

fix(chainsync): Handle error in chainsync.NewWrappedHeader #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2025
Merged

fix(chainsync): Handle error in chainsync.NewWrappedHeader #998

merged 2 commits into from
Apr 26, 2025

Conversation

arepala-uml
Copy link
Contributor

  1. Updated NewWrappedHeader to return an error when CBOR decoding fails.
  2. Modified NewMsgRollForwardNtN to return the wrapped header error.
  3. Added unit test for NewMsgRollForwardNtN to verify error propagation from NewWrappedHeader with corrupted CBOR.
  4. Modified existing test case of NewMsgRollForwardNtN function.

Closes #856

@arepala-uml
fix(chainsync): Handled CBOR decode errors in NewWrappedHeader and up…
2b45707 
…dated NewMsgRollForwardNtN

Signed-off-by: Akhil Repala <arepala@blinklabs.io>
@arepala-uml
fix(chainsync): replace fmt.Errorf with errors.New for static error m…
600bc37 
…essage

Signed-off-by: Akhil Repala <arepala@blinklabs.io>
@arepala-uml arepala-uml marked this pull request as ready for review April 26, 2025 01:11
@arepala-uml arepala-uml requested a review from a team as a code owner April 26, 2025 01:11
@wolf31o2 wolf31o2 merged commit 34fe34a into main Apr 26, 2025
9 of 13 checks passed
@wolf31o2 wolf31o2 deleted the new_wrapped_header branch April 26, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agaffney agaffney agaffney approved these changes

@wolf31o2 wolf31o2 Awaiting requested review from wolf31o2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle error in chainsync.NewWrappedHeader
3 participants
@arepala-uml @agaffney @wolf31o2
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy