Skip to content

feat(b-dropdown): new split-button-type prop to specify split button type (closes #3694) #3695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 15, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Jul 15, 2019

Describe the PR

Add a new prop split-button-type for specifying the split button's type (button, submit, reset, defaults to button).

The prop has no effect if split-to or split-href is set.

Closes #3694

To Do:

  • Docs update
  • new unit test(s)

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #3695 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3695      +/-   ##
==========================================
+ Coverage   99.26%   99.26%   +<.01%     
==========================================
  Files         223      223              
  Lines        4363     4366       +3     
  Branches     1231     1232       +1     
==========================================
+ Hits         4331     4334       +3     
  Misses         26       26              
  Partials        6        6
Impacted Files Coverage Δ
src/components/dropdown/dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a5faa...ea6b55b. Read the comment docs.

@tmorehouse tmorehouse requested a review from jacobmllr95 July 15, 2019 18:58
@tmorehouse tmorehouse changed the title feat(b-dropdown): new prop to specify button type for split button (closes #3694) feat(b-dropdown): new split-button-type prop to specify split button type (closes #3694) Jul 15, 2019
@tmorehouse tmorehouse merged commit 1157589 into dev Jul 15, 2019
@jacobmllr95 jacobmllr95 deleted the issue/3694 branch July 15, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

b-dropdown: The ability to set attributes and properties for b-button object
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy