-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(b-table): add sortKey
option for no-local-sorting
events
#5746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(b-table): add sortKey
option for no-local-sorting
events
#5746
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 862274b:
|
Codecov Report
@@ Coverage Diff @@
## dev #5746 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 284 284
Lines 9554 9557 +3
Branches 2520 2521 +1
=========================================
+ Hits 9554 9557 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/iyg7f5xud |
sortKey
option for no-local-sorting
events
Thanks for clean-up @jackmu95 😄 |
Describe the PR
When using
no-local-sorting
I have come across a few cases where I'd like to control what thesortBy
value is for a specific column in the emitted context . This helps if I have fields that are more custom and don't exactly match my data source in naming or composition.This PR introduces a
sortKey
option on the fields definition that allows one to specify what key to use whenno-local-sorting
istrue
.PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: