Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(UI): modernize host groups add/edit forms #7023

Conversation

Med1233
Copy link
Contributor

@Med1233 Med1233 commented Mar 21, 2025

Description

this PR is a copy of PR

The code is reviewed and approved in here PR

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x
  • 24.10.x
  • master

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

Copy link

Code coverage report for centreon centreon 🚀

Coverage after merging MON-16024002-front-end-hostgroup-add-edit-new into MON-159659-Hostgroup-Add-Edit will be
93.08%
Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
centreon/www/front_src/src/AdditionalConnectorConfiguration/Modal
   useModal.tsx100%100%100%100%
centreon/www/front_src/src/Configuration
   models.ts100%100%100%100%
centreon/www/front_src/src/Configuration/ConfigurationBase
   ConfigurationBase.tsx93.33%84.62%100%100%33, 37
   Page.styles.ts100%100%100%100%
   Page.tsx100%100%100%100%
   atoms.ts100%100%100%100%
   constants.ts100%100%100%100%
   translatedLabels.ts100%100%100%100%
centreon/www/front_src/src/Configuration/ConfigurationBase/Dialogs
   CloseModal.tsx70.83%100%50%75%26–28, 33
   index.ts100%100%100%100%
centreon/www/front_src/src/Configuration/ConfigurationBase/Dialogs/Delete
   useDelete.ts96.08%91.67%100%96.97%76–77
centreon/www/front_src/src/Configuration/ConfigurationBase/Dialogs/Duplicate
   useDuplicate.ts95.35%83.33%100%96.55%83–84
centreon/www/front_src/src/Configuration/ConfigurationBase/Filters
   Filters.styles.ts100%100%100%100%
   useSearch.ts95%50%100%100%40
centreon/www/front_src/src/Configuration/ConfigurationBase/Filters/AdvancedFilters
   PopoverFilter.tsx100%100%100%100%
   useFilters.ts100%100%100%100%
centreon/www/front_src/src/Configuration/ConfigurationBase/Listing
   Listing.tsx100%100%100%100%
   atoms.ts100%100%100%100%
   useListing.ts71.05%0%57.14%79.31%51, 60, 64, 64, 64–65, 67, 70
   useLoadData.ts96.88%90%100%100%48
centreon/www/front_src/src/Configuration/ConfigurationBase/Listing/ActionsBar
   Actions.styles.ts100%100%100%100%
   ActionsBar.tsx100%100%100%100%
   AddAction.tsx100%100%100%100%
centreon/www/front_src/src/Configuration/ConfigurationBase/Listing/ActionsBar/MassiveActions
   MassiveActions.tsx100%100%100%100%
   MoreActions.tsx100%100%100%100%
   useMassiveActions.ts91.49%66.67%100%93.75%65–66, 85–86
centreon/www/front_src/src/Configuration/ConfigurationBase/Listing/Columns/Status
   useStatus.ts90.57%87.50%100%90.63%42–43, 67–68, 70
centreon/www/front_src/src/Configuration/ConfigurationBase/Modal
   Modal.styles.ts100%100%100%100%
   Modal.tsx100%100%100%100%
   useModal.ts97.10%95%100%97.62%112–113
centreon/www/front_src/src/Configuration/ConfigurationBase/Modal/Form
   Form.styles.ts100%100%100%100%
   Form.tsx100%100%100%100%
centreon/www/front_src/src/Configuration/ConfigurationBase/Specs
   Configuration.Actions.tsx100%100%100%100%
   Configuration.Filters.tsx100%100%100%100%
   Configuration.Layout.tsx100%100%100%100%
   Configuration.Modal.tsx100%100%100%100%
   initialize.tsx100%100%100%100%
   utils.ts100%100%100%100%
centreon/www/front_src/src/Configuration/ConfigurationBase/api
   index.ts100%100%100%100%
   useCreate.ts100%100%100%100%
   useDelete.ts100%100%100%100%
   useDeleteOne.ts100%100%100%100%
   useDisable.ts100%100%100%100%
   useDuplicate.ts100%100%100%100%
   useEnable.ts100%100%100%100%
   useGetAll.ts93.33%75%100%100%33
   useGetOne.tsx100%100%100%100%
   useUpdate.ts100%100%100%100%
centreon/www/front_src/src/Configuration/HostGroups
   HostGroups.tsx100%100%100%100%
   translatedLabels.ts100%100%100%100%
   useHostGroups.tsx95.24%75%100%100%41
centreon/www/front_src/src/Configuration/HostGroups/Form
   Form.styles.ts100%100%100%100%
   IconFiled.tsx100%100%100%100%
   defaultValues.ts100%100%100%100%
   index.ts100%100%100%100%
   useFormInputs.tsx100%100%100%100%
   useValidationSchema.ts100%100%100%100%
centreon/www/front_src/src/Configuration/HostGroups/Specs
   HostGroups.Filters.tsx100%100%100%100%
   HostGroups.Listing.tsx100%100%100%100%
   HostGroups.Modal.tsx100%100%100%100%
   initialize.tsx100%100%100%100%
   utils.ts100%100%100%100%
centreon/www/front_src/src/Configuration/HostGroups/api
   decoders.ts100%100%100%100%
   endpoints.ts100%100%100%100%
   index.ts100%100%100%100%

@Med1233 Med1233 marked this pull request as ready for review March 21, 2025 21:14
@Med1233 Med1233 requested review from a team as code owners March 21, 2025 21:14
@Med1233 Med1233 requested review from quborg, Noha-ElAbrouki and smau-centreon and removed request for a team March 21, 2025 21:14
Copy link

Code coverage report for centreon-packages-ui component 🚀

Coverage after merging MON-16024002-front-end-hostgroup-add-edit-new into MON-159659-Hostgroup-Add-Edit will be
77.43%
Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
centreon/packages/ui/src/Form/Inputs
   index.tsx67.61%46.67%76.92%85.71%101, 107, 149, 149, 166, 176, 179, 179, 179, 179, 179, 192, 202, 222–223, 238, 258, 258, 265, 265
   models.ts100%100%100%100%

@Med1233 Med1233 merged commit 5fc36d8 into MON-159659-Hostgroup-Add-Edit Mar 21, 2025
340 of 341 checks passed
@Med1233 Med1233 deleted the MON-16024002-front-end-hostgroup-add-edit-new branch March 21, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy