Skip to content

Add HasField x (Signal dom r) (Signal dom a) #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2025
Merged

Add HasField x (Signal dom r) (Signal dom a) #2982

merged 1 commit into from
Jul 19, 2025

Conversation

martijnbastiaan
Copy link
Member

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files

lmbollen
lmbollen approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@lmbollen lmbollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will greatly improve code cleanliness 🚀

kleinreact
kleinreact approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@kleinreact kleinreact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Happy to have that in our next release.

@martijnbastiaan
Copy link
Member Author

Thanks all, let's merge.

@martijnbastiaan martijnbastiaan merged commit 229f243 into master Jul 19, 2025
14 checks passed
@martijnbastiaan martijnbastiaan deleted the add-has-field-signal branch July 19, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DigitalBrains1 DigitalBrains1 DigitalBrains1 left review comments

@lmbollen lmbollen lmbollen approved these changes

@kleinreact kleinreact kleinreact approved these changes

@christiaanb christiaanb Awaiting requested review from christiaanb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martijnbastiaan @DigitalBrains1 @lmbollen @kleinreact
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy