fix(localizations): Merge issues #6346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tmilewski merged 1 commit into main from tm/fix-vi-vn-merge-issues

Jul 17, 2025

Member

tmilewski commented Jul 17, 2025 •

edited by coderabbitai bot

Loading

Description

Fixes merge issues introduced in a localization PR just now.

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

Summary by CodeRabbit

Chores
- Added an empty changeset file for tracking future updates.
Style
- Improved formatting and punctuation consistency in the Vietnamese localization resource file. No changes to content or functionality.


          fix(localizations): Merge issues

a2318e4

tmilewski self-assigned this

vercel bot commented Jul 17, 2025 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 17, 2025 10:22pm

changeset-bot bot commented Jul 17, 2025

🦋 Changeset detected

Latest commit: a2318e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

clerk-cookie added the localizations label

vercel bot deployed to Preview

July 17, 2025 22:22

View deployment

tmilewski enabled auto-merge (squash)

July 17, 2025 22:23

Contributor

coderabbitai bot commented Jul 17, 2025

📝 Walkthrough

Walkthrough

An empty changeset file named little-lies-peel.md was added to the .changeset directory, containing only frontmatter delimiters without any additional content. Additionally, the Vietnamese localization resource file (vi-VN.ts) underwent formatting and punctuation corrections, such as adding missing trailing commas, adjusting semicolon usage in import statements, and modifying whitespace for consistency. No changes were made to the string content, localization keys, or the structure of the exported entities. The updates are limited to syntax formatting and punctuation within the existing exported constant.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f2e0ad and a2318e4.

📒 Files selected for processing (2)

.changeset/little-lies-peel.md (1 hunks)
packages/localizations/src/vi-VN.ts (39 hunks)

🧰 Additional context used

📓 Path-based instructions (7)

**/*.{js,jsx,ts,tsx}

Instructions used from:

Sources:
📄 CodeRabbit Inference Engine

.cursor/rules/development.mdc

packages/**/*.ts

Instructions used from:

Sources:
📄 CodeRabbit Inference Engine

.cursor/rules/development.mdc

packages/**/*.{ts,tsx,d.ts}

Instructions used from:

Sources:
📄 CodeRabbit Inference Engine

.cursor/rules/development.mdc

**/*.{ts,tsx}

Instructions used from:

Sources:
📄 CodeRabbit Inference Engine

.cursor/rules/development.mdc
.cursor/rules/typescript.mdc

packages/localizations/**/*

Instructions used from:

Sources:
📄 CodeRabbit Inference Engine

.cursor/rules/monorepo.mdc

**/*

Instructions used from:

Sources:
⚙️ CodeRabbit Configuration File

**/localizations/**/*.ts

Instructions used from:

Sources:
⚙️ CodeRabbit Configuration File

🧠 Learnings (3)

📓 Common learnings

Learnt from: dstaley
PR: clerk/javascript#6116
File: .changeset/tangy-garlics-say.md:1-2
Timestamp: 2025-06-13T16:09:53.061Z
Learning: In the Clerk JavaScript repository, contributors create intentionally empty changeset files (containing only the YAML delimiters) when a PR touches only non-published parts of the codebase (e.g., sandbox assets). This signals that no package release is required, so such changesets should not be flagged as missing content.

Learnt from: ToliaGuy
PR: clerk/javascript#6316
File: packages/localizations/src/cs-CZ.ts:795-813
Timestamp: 2025-07-15T12:56:48.352Z
Learning: In Clerk's localization files, when keys are set to `undefined` in the base English localization (en-US.ts), translated files should maintain the same `undefined` status to ensure consistency. This is the correct approach rather than attempting to translate unused/placeholder keys.

Learnt from: jacekradko
PR: clerk/javascript#5905
File: .changeset/six-ears-wash.md:1-3
Timestamp: 2025-06-26T03:27:05.535Z
Learning: In the Clerk JavaScript repository, changeset headers support single quotes syntax (e.g., '@clerk/backend': minor) and work fine with their current changesets integration, so there's no need to change them to double quotes.

.changeset/little-lies-peel.md (1)

Learnt from: dstaley
PR: clerk/javascript#6116
File: .changeset/tangy-garlics-say.md:1-2
Timestamp: 2025-06-13T16:09:53.061Z
Learning: In the Clerk JavaScript repository, contributors create intentionally empty changeset files (containing only the YAML delimiters) when a PR touches only non-published parts of the codebase (e.g., sandbox assets). This signals that no package release is required, so such changesets should not be flagged as missing content.

packages/localizations/src/vi-VN.ts (2)

Learnt from: ToliaGuy
PR: clerk/javascript#6316
File: packages/localizations/src/cs-CZ.ts:795-813
Timestamp: 2025-07-15T12:56:48.352Z
Learning: In Clerk's localization files, when keys are set to `undefined` in the base English localization (en-US.ts), translated files should maintain the same `undefined` status to ensure consistency. This is the correct approach rather than attempting to translate unused/placeholder keys.

Learnt from: CR
PR: clerk/javascript#0
File: .cursor/rules/typescript.mdc:0-0
Timestamp: 2025-06-30T10:33:45.961Z
Learning: Applies to **/*.{ts,tsx} : Use ES6 imports/exports consistently

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: semgrep-cloud-platform/scan
GitHub Check: Build Packages
GitHub Check: Formatting | Dedupe | Changeset
GitHub Check: semgrep/ci
GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (2)

.changeset/little-lies-peel.md (1)

1-2: Empty changeset acknowledged

An intentionally blank changeset correctly signals that no package release is required.
No action needed.

packages/localizations/src/vi-VN.ts (1)

13-1238: Formatting-only updates look solid

All modifications are limited to punctuation ‒ chiefly trailing-comma additions and import-statement termination ‒ with no semantic impact on the translation map.
Type annotations remain intact (as const), placeholders ({{…}}) are untouched, and undefined keys stay undefined, so consistency with the base en-US file is preserved.

Nothing further to change. ✅

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

wobsoriano approved these changes

View reviewed changes

pkg-pr-new bot commented Jul 17, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6346

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6346

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6346

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6346

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6346

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6346

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6346

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6346

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6346

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6346

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6346

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6346

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6346

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6346

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6346

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6346

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6346

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6346

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6346

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6346

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6346

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6346

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6346

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6346

commit: a2318e4

tmilewski merged commit 170bf53 into main

39 checks passed

tmilewski deleted the tm/fix-vi-vn-merge-issues branch

July 17, 2025 22:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy