fix(localizations): Update and correctly generate and export all localizations #6352
Conversation
🦋 Changeset detectedLatest commit: 3945f8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThis change expands the localization resources in the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
packages/localizations/src/nl-BE.ts (1)
16-16: Fix locale mismatch - incorrect locale identifier for Belgian Dutch.The file is named
nl-BE.ts(Dutch Belgium) but declares the locale as'nl-NL'(Dutch Netherlands). This mismatch could cause incorrect locale selection and routing issues.- locale: 'nl-NL', + locale: 'nl-BE',
🧹 Nitpick comments (2)
packages/localizations/src/hr-HR.ts (1)
81-81: New commerce error key left undefined
cannotSubscribeUnrecoverableis a user-facing error. Surfacing the English fallback in the middle of an otherwise Croatian flow feels jarring. Please supply a translation or at least a clear TODO.packages/localizations/src/ja-JP.ts (1)
58-60: “過去の支払い期限”バッジが未翻訳
badge__pastDueAt/badge__pastDuePlanはundefinedのままです。
課金 UI で目立つ箇所なので、日本語に置き換えるか TODO を残してください。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (44)
.changeset/huge-wolves-hunt.md(1 hunks)packages/localizations/src/ar-SA.ts(3 hunks)packages/localizations/src/be-BY.ts(3 hunks)packages/localizations/src/bg-BG.ts(3 hunks)packages/localizations/src/ca-ES.ts(3 hunks)packages/localizations/src/cs-CZ.ts(4 hunks)packages/localizations/src/da-DK.ts(3 hunks)packages/localizations/src/de-DE.ts(3 hunks)packages/localizations/src/el-GR.ts(3 hunks)packages/localizations/src/en-GB.ts(3 hunks)packages/localizations/src/en-US.ts(2 hunks)packages/localizations/src/es-CR.ts(3 hunks)packages/localizations/src/es-ES.ts(3 hunks)packages/localizations/src/es-MX.ts(3 hunks)packages/localizations/src/es-UY.ts(18 hunks)packages/localizations/src/fi-FI.ts(3 hunks)packages/localizations/src/he-IL.ts(3 hunks)packages/localizations/src/hr-HR.ts(3 hunks)packages/localizations/src/hu-HU.ts(3 hunks)packages/localizations/src/id-ID.ts(3 hunks)packages/localizations/src/index.ts(2 hunks)packages/localizations/src/is-IS.ts(3 hunks)packages/localizations/src/it-IT.ts(3 hunks)packages/localizations/src/ja-JP.ts(3 hunks)packages/localizations/src/ko-KR.ts(3 hunks)packages/localizations/src/mn-MN.ts(3 hunks)packages/localizations/src/nb-NO.ts(3 hunks)packages/localizations/src/nl-BE.ts(3 hunks)packages/localizations/src/nl-NL.ts(3 hunks)packages/localizations/src/pl-PL.ts(3 hunks)packages/localizations/src/pt-BR.ts(3 hunks)packages/localizations/src/pt-PT.ts(3 hunks)packages/localizations/src/ro-RO.ts(3 hunks)packages/localizations/src/ru-RU.ts(3 hunks)packages/localizations/src/sk-SK.ts(4 hunks)packages/localizations/src/sr-RS.ts(3 hunks)packages/localizations/src/sv-SE.ts(3 hunks)packages/localizations/src/th-TH.ts(3 hunks)packages/localizations/src/tr-TR.ts(3 hunks)packages/localizations/src/uk-UA.ts(3 hunks)packages/localizations/src/utils/generate.ts(2 hunks)packages/localizations/src/vi-VN.ts(3 hunks)packages/localizations/src/zh-CN.ts(3 hunks)packages/localizations/src/zh-TW.ts(5 hunks)
🧰 Additional context used
📓 Path-based instructions (12)
.changeset/**
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/monorepo.mdc
**/*.{js,jsx,ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/development.mdc
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/development.mdc
packages/**/*.{ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/development.mdc
packages/**/*.{ts,tsx,d.ts}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/development.mdc
packages/**/index.{js,ts}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/development.mdc
**/*.{ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/development.mdc
- .cursor/rules/typescript.mdc
packages/localizations/**/*
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/monorepo.mdc
**/*.{js,ts,tsx,jsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/monorepo.mdc
**/index.ts
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/react.mdc
- .cursor/rules/typescript.mdc
**/*
Instructions used from:
Sources:
⚙️ CodeRabbit Configuration File
**/localizations/**/*.ts
Instructions used from:
Sources:
⚙️ CodeRabbit Configuration File
🧬 Code Graph Analysis (1)
packages/localizations/src/es-UY.ts (1)
packages/types/src/localization.ts (1)
LocalizationResource(63-63)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: Build Packages
- GitHub Check: Formatting | Dedupe | Changeset
- GitHub Check: semgrep/ci
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (164)
packages/localizations/src/cs-CZ.ts (6)
59-60: LGTM - New badge translations are appropriate.The Czech translations for the new past due badge keys are accurate and consistent with the existing badge translation patterns in the file.
84-84: Appropriate placeholder for unrecoverable subscription error.The new
cannotSubscribeUnrecoverablekey is correctly set toundefinedas a placeholder, which is appropriate for error messages that may need special handling or have not been translated yet.
137-151: Excellent Czech translations for subscription details.The new
subscriptionDetailsobject contains comprehensive Czech translations for all subscription lifecycle fields. The translations are contextually appropriate and follow Czech localization conventions. The reordering withtitleat the end is also well-structured.
138-140: Good Czech translations for commerce action keys.The new commerce action keys (
reSubscribe,seeAllFeatures,subscribe) have accurate Czech translations that are clear and user-friendly.
155-155: Proper Czech translation for annual plan switching.The new
switchToAnnualWithAnnualPricekey includes proper Czech translation with correct variable interpolation for currency and price display.
1255-1255: Good TypeScript practice with const assertion.The
as constassertion is properly added to ensure type safety and immutability of the localization object.packages/localizations/src/ko-KR.ts (4)
58-59: Consistent placeholder usage for new badge keys.The new badge keys
badge__pastDueAtandbadge__pastDuePlanare appropriately set toundefinedas placeholders, which is consistent with the existing pattern in this Korean localization file where many keys await translation.
81-81: Appropriate placeholder for new commerce error key.The
cannotSubscribeUnrecoverablekey is correctly set toundefinedas a placeholder, maintaining consistency with other untranslated commerce keys in this file.
137-147: Consistent structure for subscription details object.The new
subscriptionDetailsobject maintains the same structure as other localization files while appropriately usingundefinedplaceholders for all keys, which is consistent with the incomplete state of the Korean translations.
151-153: Appropriate placeholders for plan switching keys.The new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare consistently set toundefinedas placeholders, following the established pattern in this localization file.packages/localizations/src/en-GB.ts (4)
58-59: New badge keys added appropriately.The new badge keys
badge__pastDueAtandbadge__pastDuePlanare properly added and set to undefined, which is appropriate for placeholder values in community-contributed localization files.
81-81: New commerce error key added correctly.The
cannotSubscribeUnrecoverablekey has been added to the commerce section as expected for the subscription-related functionality updates.
137-147: Subscription details object properly structured.The new
subscriptionDetailsobject contains all the necessary keys for subscription management functionality (beginsOn,currentBillingCycle,endsOn,nextPaymentAmount,nextPaymentOn,pastDueAt,renewsAt,subscribedOn,title). The structure follows the established pattern and all keys are appropriately set to undefined.
151-153: Plan switching keys added consistently.The new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare properly positioned within the commerce section and follow the naming convention.packages/localizations/src/nl-NL.ts (1)
58-59: Localization updates consistent with other locales.The Dutch localization file has been updated with the same new keys as the English (GB) version, maintaining consistency across locales. All new keys are appropriately set to undefined as placeholders:
- New badge keys for past due functionality
- Commerce error key for unrecoverable subscription errors
- Complete subscription details object with all necessary fields
- Plan switching keys for annual/monthly pricing
This ensures the localization schema remains uniform across all supported languages while new translations can be added in the future.
Also applies to: 81-81, 137-147, 151-153
packages/localizations/src/ca-ES.ts (4)
58-59: New badge keys added correctly for past due subscription status.The new badge keys
badge__pastDueAtandbadge__pastDuePlanfollow the existing naming convention and are appropriately set to undefined as placeholders for future translations.
81-81: New commerce error key added appropriately.The
cannotSubscribeUnrecoverablekey is properly placed within the commerce section and follows the existing pattern for error handling keys.
137-147: Comprehensive subscription details object added correctly.The new
subscriptionDetailsobject provides a complete set of keys for subscription management UI, covering billing cycles, payment dates, and subscription lifecycle events. The structure and naming conventions are consistent with the existing codebase.
151-153: Plan switching keys with pricing information added appropriately.The new keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceenhance the plan switching UI by including pricing information, which improves user experience for subscription management.packages/localizations/src/pt-PT.ts (4)
58-59: Badge keys for past due subscription status added consistently.The new badge keys match the structure used in other localization files in this PR and are properly set as undefined placeholders for future Portuguese translations.
81-81: Commerce error key added consistently across localization files.The
cannotSubscribeUnrecoverablekey is properly integrated into the Portuguese localization, maintaining consistency with the broader localization update.
137-147: Subscription details object added consistently with other localization files.The
subscriptionDetailsobject provides the same comprehensive set of keys for subscription management as implemented in other localization files in this PR, maintaining consistency across languages.
151-153: Plan switching keys with pricing added consistently.The new plan switching keys are properly structured and consistent with the implementation in other localization files in this PR, ensuring a unified approach to subscription management UI across all supported languages.
packages/localizations/src/ru-RU.ts (4)
58-59: New badge keys added correctly as placeholders.The new badge keys
badge__pastDueAtandbadge__pastDuePlanhave been properly added as undefined placeholders, which is appropriate for future translations.
81-81: New commerce error key added as placeholder.The
cannotSubscribeUnrecoverablekey has been correctly added to the commerce section as an undefined placeholder for future translation.
137-147: New subscription details object added with proper structure.The
subscriptionDetailsobject has been added with all necessary fields for subscription management UI. All fields are appropriately set to undefined as placeholders:
beginsOn,currentBillingCycle,endsOnnextPaymentAmount,nextPaymentOn,pastDueAtrenewsAt,subscribedOn,titleThis follows the expected pattern for new localization keys.
151-153: New plan switching keys added for price-aware UI.The keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricehave been added as undefined placeholders. These will support more detailed plan switching UI that includes pricing information.packages/localizations/src/zh-CN.ts (4)
58-59: New badge keys added consistently as placeholders.The new badge keys
badge__pastDueAtandbadge__pastDuePlanhave been properly added as undefined placeholders, maintaining consistency with other localization files in this PR.
81-81: Commerce error key added appropriately.The
cannotSubscribeUnrecoverablekey has been correctly added to the commerce section as an undefined placeholder, consistent with the pattern used across all localization files.
137-147: Subscription details object properly structured.The
subscriptionDetailsobject has been added with all necessary fields for subscription management functionality. All fields are appropriately set to undefined as placeholders for future Chinese translations:
- Billing cycle and timing fields (
beginsOn,currentBillingCycle,endsOn)- Payment information fields (
nextPaymentAmount,nextPaymentOn,pastDueAt)- Subscription lifecycle fields (
renewsAt,subscribedOn,title)The structure matches the expected localization pattern.
151-153: Plan switching keys added for enhanced UI.The keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricehave been added as undefined placeholders. These will enable more detailed plan switching UI with pricing context when Chinese translations are provided.packages/localizations/src/tr-TR.ts (4)
58-59: New badge keys added appropriatelyThe addition of
badge__pastDueAtandbadge__pastDuePlankeys withundefinedplaceholder values is consistent with the localization expansion. These keys are properly positioned within the badge section and follow the established naming convention.
81-81: Commerce error key added correctlyThe
cannotSubscribeUnrecoverablekey is properly added within the commerce section with an appropriateundefinedplaceholder value for future Turkish translation.
137-147: Subscription details object properly structuredThe
subscriptionDetailsnested object is well-structured with appropriate keys for subscription lifecycle information. All keys useundefinedplaceholder values, which is correct for future Turkish translations. The object placement within the commerce section is appropriate.
151-153: Plan switching keys added appropriatelyThe
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys are properly added withundefinedplaceholder values. Their positioning within the commerce section near other plan switching keys is logical and maintains good organization.packages/localizations/src/vi-VN.ts (4)
59-60: Badge keys added consistentlyThe addition of
badge__pastDueAtandbadge__pastDuePlankeys withundefinedplaceholder values is consistent with the localization expansion pattern. The keys are properly positioned within the badge section.
84-84: Commerce error key properly addedThe
cannotSubscribeUnrecoverablekey is correctly added within the commerce section with an appropriateundefinedplaceholder value for future Vietnamese translation.
141-151: Subscription details object maintains consistencyThe
subscriptionDetailsnested object is properly structured with the same keys as other localization files, ensuring consistency across the localization expansion. All keys appropriately useundefinedplaceholder values for future Vietnamese translations.
155-157: Plan switching keys maintain consistencyThe
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys are properly added withundefinedplaceholder values, maintaining consistency with the localization expansion pattern across all language files.packages/localizations/src/es-MX.ts (4)
58-59: New badge keys added appropriately as placeholders.The addition of
badge__pastDueAtandbadge__pastDuePlankeys follows the established naming convention and is consistent with the commerce/billing functionality being added. Setting them toundefinedis appropriate for placeholder values in community-maintained localization files.
81-81: Commerce error key added appropriately.The
cannotSubscribeUnrecoverablekey is a sensible addition to the commerce section for handling subscription error scenarios. The placeholder value is appropriate for this community-maintained localization file.
137-147: Subscription details object structure is well-organized.The new
subscriptionDetailsnested object provides comprehensive coverage of subscription lifecycle events with descriptive key names. The structure is well-organized and follows established conventions. All placeholder values are appropriately set toundefined.
151-153: Plan switching keys added appropriately.The addition of
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys provides necessary functionality for plan switching with pricing information. The key names are descriptive and the placeholder values are appropriate.packages/localizations/src/es-ES.ts (4)
58-59: Badge keys added consistently with other localization files.The addition of
badge__pastDueAtandbadge__pastDuePlankeys is consistent with the broader localization update and follows the established patterns. The placeholder values are appropriate for this community-maintained localization file.
81-81: Commerce error key added consistently.The
cannotSubscribeUnrecoverablekey addition maintains consistency with other Spanish localization files in this update. The placeholder approach is appropriate for community-maintained translations.
137-147: Subscription details structure maintains consistency.The
subscriptionDetailsobject structure is identical to other Spanish localization files in this update, ensuring consistency across regional variants. The comprehensive key coverage and placeholder values are appropriate.
151-153: Plan switching keys maintain consistency across Spanish localizations.The addition of
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys is consistent with other Spanish localization files in this update. This ensures uniform behavior when translations are eventually provided.packages/localizations/src/bg-BG.ts (4)
58-59: New badge keys for past due subscription status look good.The addition of
badge__pastDueAtandbadge__pastDuePlanproperly extends the badge system to handle past due subscription states. These keys are appropriately placed within the existing badge section and set toundefinedas placeholders for future Bulgarian translations.
81-81: New commerce error key is properly positioned.The
cannotSubscribeUnrecoverablekey adds appropriate error handling for subscription failures that cannot be recovered. It's logically placed within the commerce section and follows the established naming convention.
137-147: Comprehensive subscription details object is well-structured.The new
subscriptionDetailsobject provides a complete set of keys for subscription lifecycle management:
- Billing cycle information (
beginsOn,endsOn,currentBillingCycle)- Payment details (
nextPaymentAmount,nextPaymentOn)- Status tracking (
pastDueAt,renewsAt,subscribedOn)- UI elements (
title)All keys are appropriately set to
undefinedas placeholders, maintaining consistency with the community localization approach.
151-153: Plan switching keys with pricing information enhance UX.The addition of
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys provides more detailed plan switching options that include pricing information. This improves the user experience by making pricing transparent in the UI.packages/localizations/src/nl-BE.ts (4)
58-59: New badge keys for past due subscription status are properly implemented.The addition of
badge__pastDueAtandbadge__pastDuePlanextends the badge system for subscription status tracking. These keys are correctly positioned and set toundefinedas placeholders for future Dutch translations.
81-81: Commerce error key addition is appropriate.The
cannotSubscribeUnrecoverablekey provides necessary error handling for unrecoverable subscription failures. It's properly placed within the commerce section and follows naming conventions.
137-147: Subscription details object provides comprehensive billing information.The new
subscriptionDetailsobject includes all necessary keys for subscription management:
- Lifecycle dates (
beginsOn,endsOn,subscribedOn)- Payment information (
nextPaymentAmount,nextPaymentOn)- Status indicators (
pastDueAt,renewsAt,currentBillingCycle)- UI elements (
title)All keys are appropriately set to
undefinedas placeholders, consistent with the community localization approach.
151-153: Plan switching keys with pricing enhance user experience.The
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys provide pricing-aware plan switching options. This improves transparency and user experience by including pricing information directly in the UI elements.packages/localizations/src/hu-HU.ts (4)
58-59: LGTM! Badge keys added consistently.The new badge keys for past due subscription states follow the existing naming conventions and are appropriately set to
undefinedas placeholders for future Hungarian translations.
81-81: LGTM! Commerce error key added appropriately.The new
cannotSubscribeUnrecoverablekey follows the existing commerce error key pattern and is correctly set toundefinedas a placeholder for future translation.
137-147: LGTM! Subscription details object added correctly.The new
subscriptionDetailsnested object with comprehensive subscription-related keys follows the existing structure pattern. All keys are appropriately set toundefinedas placeholders for future Hungarian translations.
151-151: LGTM! Plan switching keys added consistently.The new
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys complement the existing plan switching options and follow the established naming conventions. Both are appropriately set toundefinedas placeholders.Also applies to: 153-153
packages/localizations/src/de-DE.ts (4)
58-59: LGTM! Badge keys added consistently across localization files.The new badge keys for past due subscription states are identical to other locale files and appropriately set to
undefinedas placeholders for future German translations.
83-83: LGTM! Commerce error key maintains cross-file consistency.The
cannotSubscribeUnrecoverablekey addition is consistent with other locale files and appropriately set toundefinedas a placeholder.
140-150: LGTM! Subscription details object maintains systematic consistency.The
subscriptionDetailsnested object with comprehensive subscription-related keys is identical to other locale files, ensuring consistent UI component support across all localizations.
154-154: LGTM! Plan switching and billing keys added appropriately.The new
switchToAnnualWithAnnualPrice,switchToMonthlyWithPrice, andtotalDuekeys follow the established patterns and are appropriately set toundefinedas placeholders for future German translations.Also applies to: 156-157
packages/localizations/src/da-DK.ts (4)
58-59: New badge keys added for subscription status indicators.The new badge keys
badge__pastDueAtandbadge__pastDuePlanhave been added as placeholders for Danish translations related to past due subscription statuses. These keys are currently set toundefinedand will need Danish translations to be functional.
81-81: New commerce error key added for unrecoverable subscription errors.The
cannotSubscribeUnrecoverablekey has been added as a placeholder for handling unrecoverable subscription errors. This key will need a Danish translation to provide appropriate error messaging to users.
137-147: New subscriptionDetails object added for billing cycle information.A comprehensive
subscriptionDetailsobject has been added with keys for various subscription billing information including billing cycles, payment dates, and subscription status. All keys are currently set toundefinedand will require Danish translations to support the subscription management UI.
151-153: New plan switching keys added for pricing display.The keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricehave been added to support plan switching UI with pricing information. These placeholders will need Danish translations to display pricing options to users.packages/localizations/src/es-CR.ts (4)
58-59: New badge keys added for subscription status indicators.The new badge keys
badge__pastDueAtandbadge__pastDuePlanhave been added as placeholders for Spanish (Costa Rica) translations related to past due subscription statuses. These keys are currently set toundefinedand will need Spanish translations to be functional.
81-81: New commerce error key added for unrecoverable subscription errors.The
cannotSubscribeUnrecoverablekey has been added as a placeholder for handling unrecoverable subscription errors. This key will need a Spanish translation to provide appropriate error messaging to users.
137-147: New subscriptionDetails object added for billing cycle information.A comprehensive
subscriptionDetailsobject has been added with keys for various subscription billing information including billing cycles, payment dates, and subscription status. All keys are currently set toundefinedand will require Spanish translations to support the subscription management UI.
151-153: New plan switching keys added for pricing display.The keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricehave been added to support plan switching UI with pricing information. These placeholders will need Spanish translations to display pricing options to users.packages/localizations/src/nb-NO.ts (4)
58-59: New badge keys added correctly.The addition of
badge__pastDueAtandbadge__pastDuePlankeys follows the established naming convention and are properly positioned within the badge section. These placeholders are correctly set toundefinedawaiting future Norwegian translations.
81-81: Commerce error key added appropriately.The
cannotSubscribeUnrecoverablekey is correctly positioned within the commerce section and follows the established naming pattern for error states. The placeholder value is properly set toundefined.
137-147: Subscription details object properly structured.The new
subscriptionDetailsobject is well-organized with comprehensive keys covering all aspects of subscription billing information including billing cycles, payment dates, amounts, and subscription lifecycle events. All placeholder values are correctly set toundefinedand the object structure follows TypeScript conventions.
151-151: Plan switching keys enhance existing functionality.The addition of
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys logically extends the existing plan switching functionality by including price information. These keys are properly positioned near related switching options and follow the established naming conventions.Also applies to: 153-153
packages/localizations/src/mn-MN.ts (4)
58-59: Badge keys added consistently.The addition of
badge__pastDueAtandbadge__pastDuePlankeys is consistent with the changes made across other localization files in this PR. The keys are properly positioned and follow the established naming convention with appropriateundefinedplaceholder values.
81-81: Commerce error key added consistently.The
cannotSubscribeUnrecoverablekey addition is consistent with the pattern applied across all localization files in this PR. It's properly positioned within the commerce section with the correctundefinedplaceholder value.
137-147: Subscription details object added consistently.The new
subscriptionDetailsobject with its comprehensive set of billing-related keys is consistent with the changes made across all localization files in this PR. The structure is properly formatted and all keys are appropriately set toundefinedas placeholders for future Mongolian translations.
151-151: Plan switching keys added consistently.The addition of
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys is consistent with the pattern applied across all localization files in this PR. These keys extend the existing plan switching functionality and are properly positioned with correct placeholder values.Also applies to: 153-153
packages/localizations/src/sv-SE.ts (4)
58-59: LGTM: Badge keys for past due functionality added correctlyThe new badge keys
badge__pastDueAtandbadge__pastDuePlanare appropriately placed and follow the established naming conventions. Usingundefinedas placeholders is correct for future translation work.
81-81: LGTM: Commerce error key added appropriatelyThe new
cannotSubscribeUnrecoverablekey is correctly placed within the commerce section and follows the established pattern of usingundefinedas a placeholder.
137-147: LGTM: Comprehensive subscriptionDetails object addedThe new
subscriptionDetailsobject provides a well-structured set of billing and subscription lifecycle keys. All keys follow proper naming conventions and are appropriately set toundefinedas placeholders for future translation work.
151-153: LGTM: Plan switching keys with pricing addedThe new
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys are logical extensions of the existing plan switching functionality. They follow proper naming conventions and are appropriately set as placeholders.packages/localizations/src/he-IL.ts (4)
58-59: LGTM: Badge keys for past due functionality added consistentlyThe new badge keys
badge__pastDueAtandbadge__pastDuePlanare correctly added and consistent with the pattern established across other localization files. Usingundefinedas placeholders is appropriate.
81-81: LGTM: Commerce error key added consistentlyThe new
cannotSubscribeUnrecoverablekey is correctly placed and maintains consistency with the localization update pattern across all language files.
137-147: LGTM: Comprehensive subscriptionDetails object added consistentlyThe new
subscriptionDetailsobject maintains perfect structural consistency with other localization files in this update. All keys are appropriately set toundefinedas placeholders for future Hebrew translations.
151-153: LGTM: Plan switching keys with pricing added consistentlyThe new
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys maintain consistency with the localization update pattern and are appropriately set as placeholders for future Hebrew translations.packages/localizations/src/uk-UA.ts (4)
58-59: LGTM! New badge keys properly addedThe new past due badge keys are correctly placed within the badge section and follow the established naming convention. Setting them to
undefinedas placeholders is appropriate for future translation.
81-81: LGTM! Commerce error key properly addedThe new
cannotSubscribeUnrecoverablekey is correctly placed within the commerce section and appropriately set toundefinedas a placeholder.
137-147: LGTM! Subscription details object properly structuredThe new
subscriptionDetailsobject is well-organized with appropriate keys for subscription management functionality. All keys are correctly set toundefinedas placeholders and the object is properly nested within the commerce section.
151-151: LGTM! Plan switching keys properly addedThe new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare correctly placed within the commerce section and appropriately set toundefinedas placeholders for future translation.Also applies to: 153-153
packages/localizations/src/th-TH.ts (4)
58-59: LGTM! New badge keys properly addedThe new past due badge keys are correctly placed within the badge section and follow the established naming convention. Setting them to
undefinedas placeholders is appropriate for future translation.
81-81: LGTM! Commerce error key properly addedThe new
cannotSubscribeUnrecoverablekey is correctly placed within the commerce section and appropriately set toundefinedas a placeholder.
137-147: LGTM! Subscription details object properly structuredThe new
subscriptionDetailsobject is well-organized with appropriate keys for subscription management functionality. All keys are correctly set toundefinedas placeholders and the object is properly nested within the commerce section.
151-151: LGTM! Plan switching keys properly addedThe new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare correctly placed within the commerce section and appropriately set toundefinedas placeholders for future translation.Also applies to: 153-153
packages/localizations/src/it-IT.ts (4)
58-59: LGTM: Badge keys added for subscription status.The new badge keys
badge__pastDueAtandbadge__pastDuePlanare properly placed within the badge section and follow the established naming convention. Setting them toundefinedas placeholders for future Italian translations is appropriate.
81-81: LGTM: Commerce error key added.The new
cannotSubscribeUnrecoverablekey is properly placed within the commerce section and follows the established pattern. Setting it toundefinedas a placeholder for future Italian translation is appropriate.
137-147: LGTM: Subscription details object added.The new
subscriptionDetailsnested object is well-structured with comprehensive keys for displaying subscription information. The keys are appropriately named and follow the established pattern. Setting all keys toundefinedas placeholders for future Italian translations is appropriate.
151-151: LGTM: Plan switching keys added.The new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare properly placed within the commerce section and follow the established naming convention. Setting them toundefinedas placeholders for future Italian translations is appropriate.Also applies to: 153-153
packages/localizations/src/el-GR.ts (4)
58-59: LGTM: Badge keys added for subscription status.The new badge keys
badge__pastDueAtandbadge__pastDuePlanare properly placed within the badge section and follow the established naming convention. Setting them toundefinedas placeholders for future Greek translations is appropriate.
81-81: LGTM: Commerce error key added.The new
cannotSubscribeUnrecoverablekey is properly placed within the commerce section and follows the established pattern. Setting it toundefinedas a placeholder for future Greek translation is appropriate.
137-147: LGTM: Subscription details object added.The new
subscriptionDetailsnested object is well-structured with comprehensive keys for displaying subscription information. The keys are appropriately named and follow the established pattern. Setting all keys toundefinedas placeholders for future Greek translations is appropriate.
151-151: LGTM: Plan switching keys added.The new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare properly placed within the commerce section and follow the established naming convention. Setting them toundefinedas placeholders for future Greek translations is appropriate.Also applies to: 153-153
packages/localizations/src/id-ID.ts (4)
58-59: New badge keys added appropriately as placeholders.The addition of
badge__pastDueAtandbadge__pastDuePlankeys follows the established pattern of usingundefinedas placeholders for future translations. These keys are consistent with the subscription and billing feature expansion mentioned in the PR objectives.
81-81: Commerce error key added correctly.The
cannotSubscribeUnrecoverablekey is properly added as a placeholder within the commerce section, maintaining consistency with the existing structure.
137-147: Subscription details object structure is well-organized.The new
subscriptionDetailsnested object contains all the necessary keys for subscription lifecycle management:
beginsOn,endsOn,subscribedOnfor date trackingcurrentBillingCycle,nextPaymentAmount,nextPaymentOnfor billing informationpastDueAt,renewsAtfor status trackingtitlefor UI labelingAll keys are appropriately set to
undefinedas placeholders for future Indonesian translations.
151-153: Plan switching keys added consistently.The
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys are properly integrated into the commerce section, following the established naming convention and placeholder pattern.packages/localizations/src/is-IS.ts (4)
58-59: Badge keys added consistently across locales.The
badge__pastDueAtandbadge__pastDuePlankeys are added with the same structure as other localization files, maintaining consistency across the entire localization package.
81-81: Commerce error key maintains structural consistency.The
cannotSubscribeUnrecoverablekey addition follows the same pattern as other localization files in this PR, ensuring uniform expansion of commerce error handling across all supported languages.
137-147: Subscription details structure mirrors other locales perfectly.The
subscriptionDetailsobject contains identical keys to other localization files:
- Proper nesting within the commerce section
- All necessary subscription lifecycle keys present
- Consistent use of
undefinedplaceholders- Maintains alphabetical ordering of keys
This structural consistency is essential for maintainability across the entire localization package.
151-153: Plan switching keys complete the commerce expansion.The addition of
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricecompletes the set of new commerce-related keys, maintaining consistency with the broader localization update across all supported languages.packages/localizations/src/be-BY.ts (4)
58-59: LGTM! New badge keys added for past due status.The new badge keys
badge__pastDueAtandbadge__pastDuePlanfollow the established naming convention and are appropriately set toundefinedas placeholders for future translations.
81-81: LGTM! New error key added for subscription handling.The new
cannotSubscribeUnrecoverablekey is appropriately added to handle unrecoverable subscription errors and follows the existing naming convention.
137-147: LGTM! Comprehensive subscription details object added.The new
subscriptionDetailsobject includes all essential subscription-related properties for billing and subscription management. The structure is well-organized and all properties are appropriately set toundefinedas placeholders.
151-153: LGTM! New plan switching keys with pricing information.The new keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceenhance the plan switching UI with pricing-aware labels. The naming is descriptive and consistent with existing commerce keys.packages/localizations/src/ar-SA.ts (4)
58-59: LGTM! Badge keys consistently added across localizations.The new badge keys
badge__pastDueAtandbadge__pastDuePlanare consistently added in the same positions as other localization files, maintaining schema consistency.
81-81: LGTM! Error key consistently added.The
cannotSubscribeUnrecoverableerror key is consistently added in the same position across localization files, maintaining schema consistency.
137-147: LGTM! Subscription details object consistently structured.The
subscriptionDetailsobject maintains the same structure and property set as other localization files, ensuring schema consistency across all supported locales.
151-153: LGTM! Plan switching keys consistently added.The plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare consistently added across localization files, maintaining schema consistency.packages/localizations/src/pl-PL.ts (4)
58-59: LGTM! New badge keys added correctly.The new badge keys
badge__pastDueAtandbadge__pastDuePlanare properly structured as placeholders withundefinedvalues, following the established pattern for future translations.
81-81: LGTM! New commerce error key added correctly.The new
cannotSubscribeUnrecoverablekey is properly placed within the commerce section withundefinedas a placeholder for future translation.
137-147: LGTM! New subscriptionDetails object added correctly.The new
subscriptionDetailsobject with all its nested keys is properly structured withundefinedplaceholders. The naming convention and nesting follows the established patterns within the commerce section.
151-151: LGTM! New plan switching keys added correctly.The new
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys are properly positioned within the commerce section withundefinedplaceholders, following the established pattern for plan switching functionality.Also applies to: 153-153
packages/localizations/src/sk-SK.ts (5)
58-59: LGTM! New badge keys added correctly.The new badge keys
badge__pastDueAtandbadge__pastDuePlanare properly structured as placeholders withundefinedvalues, consistent with the established pattern for future translations.
81-81: LGTM! New commerce error key added correctly.The new
cannotSubscribeUnrecoverablekey is properly placed within the commerce section withundefinedas a placeholder for future translation.
137-147: LGTM! New subscriptionDetails object added correctly.The new
subscriptionDetailsobject with all its nested keys is properly structured withundefinedplaceholders. The naming convention and nesting follows the established patterns within the commerce section.
151-151: LGTM! New plan switching keys added correctly.The new
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys are properly positioned within the commerce section withundefinedplaceholders, following the established pattern for plan switching functionality.Also applies to: 153-153
850-850: LGTM! Minor structural adjustment.The repositioning of the
web3_missing_identifierkey within theunstable__errorssection is a minor organizational change without any semantic impact.packages/localizations/src/utils/generate.ts (1)
26-26: LGTM: es-UY locale integration is correctly implemented.The import statement and function call for the Spanish (Uruguay) localization are properly added in alphabetical order, following the established pattern for other locales.
Also applies to: 185-185
.changeset/huge-wolves-hunt.md (1)
1-6: LGTM: Changeset properly documents the sr-RS locale addition.The changeset follows the correct format with appropriate patch version increment for adding a new localization resource.
packages/localizations/src/index.ts (1)
21-21: LGTM: Export reordering and sr-RS addition are correctly implemented.The exports maintain alphabetical ordering and the new Serbian (Serbia) localization is properly added between
skSKandsvSE. All exports follow the established pattern and use tree-shaking friendly named exports.Also applies to: 35-35, 40-40
packages/localizations/src/en-US.ts (1)
47-48: LGTM: Localization key reordering and additions are well-structured.The reordering of badge and commerce keys improves logical organization, and the new
switchToAnnualWithAnnualPricekey properly follows established naming conventions with appropriate English text. All changes maintain consistency with existing localization patterns.Also applies to: 127-140, 144-144
packages/localizations/src/hr-HR.ts (2)
58-60: Missing Croatian strings for new “past-due” badge labels
badge__pastDueAtandbadge__pastDuePlanremainundefined. These labels show up prominently on subscription UIs – leaving them blank will fall back to the default locale and break language consistency.If you don’t have the final wording yet, consider adding a TODO with the intended Croatian copy so translators can quickly spot it.
137-147: Placeholders must be preserved when localisingsubscriptionDetails+ plan-switch stringsAll fields inside
subscriptionDetails, plus
switchToAnnualWithAnnualPrice/switchToMonthlyWithPrice, will carry interpolation tokens such as{{amount}},{{date}},{{annualPrice}}, etc.When you later add the Croatian text, double-check that every placeholder from the English base file is copied verbatim (including braces and casing) to avoid runtime formatting errors.
Also applies to: 151-153
packages/localizations/src/ja-JP.ts (2)
81-81:cannotSubscribeUnrecoverableの翻訳が抜けています購読フローで致命的エラーが英語のまま表示される可能性があります。早めに日本語訳を補完してください。
137-147: 変数プレースホルダの保持を忘れずに
subscriptionDetails.*とプラン切替ラベルには{{date}},{{amount}},{{annualPrice}}などのトークンが入ります。
翻訳追加時にこれらをそのまま残さないと実行時に崩れますのでご注意ください。Also applies to: 151-153
packages/localizations/src/fi-FI.ts (4)
58-59: New badge keys added for past due status.The addition of
badge__pastDueAtandbadge__pastDuePlankeys is consistent with the standardization effort for subscription status indicators across all locales. These placeholder values will need Finnish translations once the UI implementation is complete.
81-81: New commerce error key added.The
cannotSubscribeUnrecoverablekey addition aligns with enhanced error handling for subscription scenarios. The undefined placeholder is appropriate for this initial implementation.
137-147: New subscription details object added.The
subscriptionDetailsobject with comprehensive billing and subscription lifecycle keys (beginsOn, currentBillingCycle, endsOn, etc.) provides a complete structure for subscription management UI. All keys are properly initialized as undefined placeholders.
151-153: New plan switching keys added.The addition of
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys enhances the plan switching functionality with price-specific messaging. These undefined placeholders maintain consistency with the overall approach.packages/localizations/src/ro-RO.ts (4)
58-59: Badge keys consistently added across locales.The addition of
badge__pastDueAtandbadge__pastDuePlanin the Romanian localization matches the pattern established in other locale files. The undefined placeholders maintain consistency until Romanian translations are provided.
81-81: Commerce error key added consistently.The
cannotSubscribeUnrecoverablekey addition follows the same pattern as other locales, ensuring consistent error handling capabilities across all supported languages.
137-147: Subscription details structure maintained.The
subscriptionDetailsobject structure is identical to other locale files, ensuring consistent subscription management UI capabilities. All nine keys (beginsOn, currentBillingCycle, endsOn, nextPaymentAmount, nextPaymentOn, pastDueAt, renewsAt, subscribedOn, title) are properly defined as undefined placeholders.
151-153: Plan switching keys added consistently.The
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys maintain the same structure as other locale files, ensuring consistent plan switching functionality across all supported languages.packages/localizations/src/pt-BR.ts (4)
58-59: New badge keys added for past due status - translations neededThe new badge keys
badge__pastDueAtandbadge__pastDuePlanhave been properly added withundefinedplaceholders. These keys will need Portuguese translations to be completed.
83-83: New commerce error key added - translation neededThe new key
cannotSubscribeUnrecoverablehas been properly added for handling unrecoverable subscription errors. A Portuguese translation will need to be provided.
141-151: New subscriptionDetails object added - translations neededThe new
subscriptionDetailsobject has been properly structured with comprehensive billing cycle keys. All keys (beginsOn,currentBillingCycle,endsOn,nextPaymentAmount,nextPaymentOn,pastDueAt,renewsAt,subscribedOn,title) will need Portuguese translations to be completed.
155-157: New plan switching keys with pricing added - translations neededThe new keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricehave been properly added to enhance the plan switching UI with pricing information. Portuguese translations will need to be provided for these keys.packages/localizations/src/sr-RS.ts (4)
58-59: New badge keys added for past due status - translations neededThe new badge keys
badge__pastDueAtandbadge__pastDuePlanhave been properly added withundefinedplaceholders. These keys will need Serbian translations to be completed.
81-81: New commerce error key added - translation neededThe new key
cannotSubscribeUnrecoverablehas been properly added for handling unrecoverable subscription errors. A Serbian translation will need to be provided.
137-147: New subscriptionDetails object added - translations neededThe new
subscriptionDetailsobject has been properly structured with comprehensive billing cycle keys. All keys (beginsOn,currentBillingCycle,endsOn,nextPaymentAmount,nextPaymentOn,pastDueAt,renewsAt,subscribedOn,title) will need Serbian translations to be completed.
151-153: New plan switching keys with pricing added - translations neededThe new keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricehave been properly added to enhance the plan switching UI with pricing information. Serbian translations will need to be provided for these keys.packages/localizations/src/zh-TW.ts (6)
58-59: New commerce badge keys added correctly.The new badge keys
badge__pastDueAtandbadge__pastDuePlanare properly added as undefined placeholders, consistent with the pattern for untranslated keys in community-maintained localization files.
81-81: New commerce error key added correctly.The
cannotSubscribeUnrecoverableerror key is properly added as an undefined placeholder for future translation.
137-147: New subscription details object added correctly.The
subscriptionDetailsobject with comprehensive subscription lifecycle keys is properly structured with all keys set to undefined as placeholders. This provides a solid foundation for future subscription UI translations.
151-153: New plan switching keys added correctly.The
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys are properly added as undefined placeholders for plan switching UI elements that include pricing information.
240-246: Minor formatting improvements in organizationList section.The indentation adjustments in the organizationList section improve code consistency without affecting functionality.
844-844: New password strength suggestion key added correctly.The
repeatedkey in the password strength suggestions is properly added as an undefined placeholder, consistent with the pattern for untranslated keys.packages/localizations/src/es-UY.ts (6)
1-11: Appropriate disclaimer added for community-maintained localization.The disclaimer header properly sets expectations for community-contributed localization files, clarifying that Clerk doesn't guarantee accuracy or completeness. This is consistent with the coding guidelines for localization files.
17-49: Comprehensive apiKeys section added correctly.The apiKeys section provides well-structured placeholder support for API key management features. All keys are appropriately set to undefined, following the pattern for untranslated features in community-maintained localization files.
69-158: Comprehensive commerce section added correctly.The commerce section provides extensive placeholder support for subscription management, billing, checkout, and payment features. The structure is well-organized with appropriate nested objects, and all keys are properly set to undefined as placeholders for future translations.
50-1257: Existing Spanish translations are appropriate and professional.The existing Spanish translations throughout the file use appropriate, formal language suitable for a professional application. The translations appear accurate and contextually appropriate for UI elements. No offensive or inappropriate language was detected.
254-1242: Extensive feature additions provide comprehensive localization coverage.The substantial additions of billing pages, organization profiles, user profiles, reverification, and other features provide comprehensive placeholder support for the full Clerk feature set. The structure is consistent with the LocalizationResource type and follows the pattern of mixing translated content with undefined placeholders for incomplete translations.
15-1258: File structure and typing are correctly implemented.The file properly implements the LocalizationResource interface with the correct locale identifier 'es-UY' and maintains type safety with the 'as const' assertion. The overall structure is consistent with other localization files in the package.
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
📝 WalkthroughWalkthroughThis update introduces new localization keys related to subscription and billing features across all supported language resource files in the codebase. Specifically, it adds two new badge keys ( 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/localizations/src/ca-ES.ts (1)
58-59: Future translation completion neededAll new keys are currently undefined placeholders. Actual Catalan translations will need to be provided to complete the localization support for these subscription and billing features.
Also applies to: 81-81, 137-147, 151-153
packages/localizations/src/sv-SE.ts (1)
58-59: Future translation completion neededAll new keys are currently undefined placeholders. Actual Swedish translations will need to be provided to complete the localization support for these subscription and billing features.
Also applies to: 81-81, 137-147, 151-153
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (44)
.changeset/huge-wolves-hunt.md(1 hunks)packages/localizations/src/ar-SA.ts(3 hunks)packages/localizations/src/be-BY.ts(3 hunks)packages/localizations/src/bg-BG.ts(3 hunks)packages/localizations/src/ca-ES.ts(3 hunks)packages/localizations/src/cs-CZ.ts(4 hunks)packages/localizations/src/da-DK.ts(3 hunks)packages/localizations/src/de-DE.ts(3 hunks)packages/localizations/src/el-GR.ts(3 hunks)packages/localizations/src/en-GB.ts(3 hunks)packages/localizations/src/en-US.ts(2 hunks)packages/localizations/src/es-CR.ts(3 hunks)packages/localizations/src/es-ES.ts(3 hunks)packages/localizations/src/es-MX.ts(3 hunks)packages/localizations/src/es-UY.ts(18 hunks)packages/localizations/src/fi-FI.ts(3 hunks)packages/localizations/src/he-IL.ts(3 hunks)packages/localizations/src/hr-HR.ts(3 hunks)packages/localizations/src/hu-HU.ts(3 hunks)packages/localizations/src/id-ID.ts(3 hunks)packages/localizations/src/index.ts(2 hunks)packages/localizations/src/is-IS.ts(3 hunks)packages/localizations/src/it-IT.ts(3 hunks)packages/localizations/src/ja-JP.ts(3 hunks)packages/localizations/src/ko-KR.ts(3 hunks)packages/localizations/src/mn-MN.ts(3 hunks)packages/localizations/src/nb-NO.ts(3 hunks)packages/localizations/src/nl-BE.ts(3 hunks)packages/localizations/src/nl-NL.ts(3 hunks)packages/localizations/src/pl-PL.ts(3 hunks)packages/localizations/src/pt-BR.ts(3 hunks)packages/localizations/src/pt-PT.ts(3 hunks)packages/localizations/src/ro-RO.ts(3 hunks)packages/localizations/src/ru-RU.ts(3 hunks)packages/localizations/src/sk-SK.ts(4 hunks)packages/localizations/src/sr-RS.ts(3 hunks)packages/localizations/src/sv-SE.ts(3 hunks)packages/localizations/src/th-TH.ts(3 hunks)packages/localizations/src/tr-TR.ts(3 hunks)packages/localizations/src/uk-UA.ts(3 hunks)packages/localizations/src/utils/generate.ts(2 hunks)packages/localizations/src/vi-VN.ts(3 hunks)packages/localizations/src/zh-CN.ts(3 hunks)packages/localizations/src/zh-TW.ts(5 hunks)
🧰 Additional context used
📓 Path-based instructions (12)
.changeset/**
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/monorepo.mdc
**/*.{js,jsx,ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/development.mdc
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/development.mdc
packages/**/*.{ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/development.mdc
packages/**/*.{ts,tsx,d.ts}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/development.mdc
packages/**/index.{js,ts}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/development.mdc
**/*.{ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/development.mdc
- .cursor/rules/typescript.mdc
packages/localizations/**/*
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/monorepo.mdc
**/*.{js,ts,tsx,jsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/monorepo.mdc
**/index.ts
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/react.mdc
- .cursor/rules/typescript.mdc
**/*
Instructions used from:
Sources:
⚙️ CodeRabbit Configuration File
**/localizations/**/*.ts
Instructions used from:
Sources:
⚙️ CodeRabbit Configuration File
🧬 Code Graph Analysis (1)
packages/localizations/src/es-UY.ts (1)
packages/types/src/localization.ts (1)
LocalizationResource(63-63)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (23)
- GitHub Check: Integration Tests (astro, chrome)
- GitHub Check: Integration Tests (nextjs, chrome, 15)
- GitHub Check: Integration Tests (vue, chrome)
- GitHub Check: Integration Tests (react-router, chrome)
- GitHub Check: Integration Tests (expo-web, chrome)
- GitHub Check: Integration Tests (billing, chrome)
- GitHub Check: Integration Tests (nuxt, chrome)
- GitHub Check: Integration Tests (nextjs, chrome, 14)
- GitHub Check: Integration Tests (tanstack-react-router, chrome)
- GitHub Check: Integration Tests (tanstack-react-start, chrome)
- GitHub Check: Integration Tests (localhost, chrome)
- GitHub Check: Integration Tests (elements, chrome)
- GitHub Check: Integration Tests (generic, chrome)
- GitHub Check: Integration Tests (sessions, chrome)
- GitHub Check: Integration Tests (ap-flows, chrome)
- GitHub Check: Integration Tests (quickstart, chrome)
- GitHub Check: Integration Tests (express, chrome)
- GitHub Check: Publish with pkg-pr-new
- GitHub Check: Static analysis
- GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
- GitHub Check: Unit Tests (22, **)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (173)
packages/localizations/src/bg-BG.ts (4)
58-59: LGTM - Badge keys properly added as placeholdersThe new badge keys
badge__pastDueAtandbadge__pastDuePlanare appropriately added as undefined placeholders for future translation work. These appear to be related to subscription status indicators.
81-81: LGTM - Commerce error key properly addedThe new
cannotSubscribeUnrecoverablekey is correctly placed in the commerce section as an undefined placeholder, likely for handling unrecoverable subscription errors.
137-147: LGTM - Subscription details object properly structuredThe new
subscriptionDetailsobject with comprehensive subscription lifecycle keys is well-structured and properly placed. The keys cover all essential subscription information (billing cycles, payment dates, subscription status) and are appropriately set as undefined placeholders.
151-153: LGTM - Plan switching keys properly addedThe new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare correctly added as undefined placeholders, providing the infrastructure for pricing-aware plan switching UI elements.packages/localizations/src/ru-RU.ts (4)
58-59: LGTM - Badge keys consistently added as placeholdersThe new badge keys
badge__pastDueAtandbadge__pastDuePlanare properly added as undefined placeholders, consistent with the pattern across other localization files in this PR.
81-81: LGTM - Commerce error key properly positionedThe
cannotSubscribeUnrecoverablekey is correctly placed in the commerce section as an undefined placeholder, maintaining consistency with the coordinated localization update.
137-147: LGTM - Subscription details object properly implementedThe
subscriptionDetailsobject with comprehensive subscription management keys is well-structured and appropriately placed. The undefined placeholder values are consistent with the community-contributed localization approach.
151-153: LGTM - Plan switching keys properly addedThe plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare correctly added as undefined placeholders, completing the subscription/billing UI infrastructure updates.packages/localizations/src/uk-UA.ts (1)
58-59: LGTM! Clean addition of new localization keys.The new commerce and badge-related keys have been properly added as undefined placeholders, following the established pattern. This aligns with the PR objective to update all localizations with new subscription and billing-related keys.
Also applies to: 81-81, 137-147, 151-151, 153-153
packages/localizations/src/hu-HU.ts (1)
58-59: LGTM! Consistent localization updates.The Hungarian localization has been updated with the same new commerce and badge keys as other localization files in this PR. All keys are properly set as undefined placeholders, maintaining consistency across the codebase.
Also applies to: 81-81, 137-147, 151-151, 153-153
packages/localizations/src/mn-MN.ts (4)
58-59: LGTM: New badge keys added correctlyThe new badge keys
badge__pastDueAtandbadge__pastDuePlanare properly added as placeholders for future translation work. These keys align with the subscription billing features being added across all localization files.
81-81: LGTM: New commerce error key addedThe
cannotSubscribeUnrecoverableerror key is properly added as a placeholder under the commerce section, consistent with the subscription feature expansion.
137-147: LGTM: Subscription details object properly structuredThe new
subscriptionDetailsobject is well-structured with comprehensive keys for subscription lifecycle management:
- Billing cycle information (
beginsOn,endsOn,currentBillingCycle)- Payment details (
nextPaymentAmount,nextPaymentOn,pastDueAt)- Subscription timeline (
renewsAt,subscribedOn)- UI title key
All keys are properly set to
undefinedas placeholders.
151-153: LGTM: Plan switching keys added correctlyThe new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare properly added as placeholders, providing more specific price-aware UI text options compared to the existing basic switching keys.packages/localizations/src/tr-TR.ts (4)
58-59: LGTM: Consistent badge key additionsThe new badge keys
badge__pastDueAtandbadge__pastDuePlanare properly added as placeholders, maintaining consistency with the localization structure updates across all language files.
81-81: LGTM: Commerce error key properly addedThe
cannotSubscribeUnrecoverableerror key is correctly placed under the commerce section as a placeholder for future Turkish translation work.
137-147: LGTM: Well-structured subscription details objectThe
subscriptionDetailsobject is properly implemented with all necessary keys for subscription management UI:
- Timeline keys (
beginsOn,endsOn,subscribedOn,renewsAt)- Billing information (
currentBillingCycle,nextPaymentAmount,nextPaymentOn)- Status indicators (
pastDueAt)- UI elements (
title)All keys are appropriately set to
undefinedas translation placeholders.
151-153: LGTM: Plan switching keys added consistentlyThe new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare properly added, providing more granular control over subscription plan switching UI text with price information.packages/localizations/src/vi-VN.ts (4)
59-60: LGTM: New badge keys added as placeholdersThe new badge keys
badge__pastDueAtandbadge__pastDuePlanhave been properly added as undefined placeholders. These will need Vietnamese translations once the feature requirements are finalized.
84-84: LGTM: Commerce error key addedThe new
cannotSubscribeUnrecoverablekey has been properly added as an undefined placeholder in the commerce section. This will need Vietnamese translation for the unrecoverable subscription error scenario.
141-151: LGTM: Subscription details object addedThe new
subscriptionDetailsobject with comprehensive billing lifecycle keys has been properly structured. All keys (beginsOn,currentBillingCycle,endsOn,nextPaymentAmount,nextPaymentOn,pastDueAt,renewsAt,subscribedOn,title) are correctly set as undefined placeholders.
155-157: LGTM: Plan switching keys addedThe new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricehave been properly added as undefined placeholders. These will need Vietnamese translations for the enhanced plan switching UI.packages/localizations/src/ar-SA.ts (4)
58-59: LGTM: New badge keys added as placeholdersThe new badge keys
badge__pastDueAtandbadge__pastDuePlanhave been properly added as undefined placeholders. These will need Arabic translations once the feature requirements are finalized.
81-81: LGTM: Commerce error key addedThe new
cannotSubscribeUnrecoverablekey has been properly added as an undefined placeholder in the commerce section. This will need Arabic translation for the unrecoverable subscription error scenario.
137-147: LGTM: Subscription details object addedThe new
subscriptionDetailsobject with comprehensive billing lifecycle keys has been properly structured. All keys (beginsOn,currentBillingCycle,endsOn,nextPaymentAmount,nextPaymentOn,pastDueAt,renewsAt,subscribedOn,title) are correctly set as undefined placeholders.
151-153: LGTM: Plan switching keys addedThe new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricehave been properly added as undefined placeholders. These will need Arabic translations for the enhanced plan switching UI.packages/localizations/src/de-DE.ts (4)
58-59: New badge keys added for subscription status indicators.The addition of
badge__pastDueAtandbadge__pastDuePlankeys with undefined values is consistent with the localization update. These will need German translations in the future to display past due subscription information to users.
83-83: New commerce error key added for unrecoverable subscription failures.The
cannotSubscribeUnrecoverablekey has been added as a placeholder for handling subscription errors that cannot be recovered. This will need a German translation for proper error messaging.
140-150: New subscriptionDetails object added with comprehensive billing information keys.The
subscriptionDetailsobject includes all necessary keys for displaying detailed subscription information (beginsOn,currentBillingCycle,endsOn,nextPaymentAmount,nextPaymentOn,pastDueAt,renewsAt,subscribedOn,title). The structure is well-organized and consistent with the existing localization patterns.
154-156: New plan switching keys added with price display functionality.The addition of
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys provides enhanced plan switching capabilities with price information display. These keys will need German translations that include proper formatting for price display.packages/localizations/src/th-TH.ts (4)
58-59: Consistent badge keys added for subscription status indicators.The Thai localization file correctly includes the same
badge__pastDueAtandbadge__pastDuePlankeys as other localization files, maintaining consistency across the codebase. These will need Thai translations for proper localization.
81-81: Commerce error key added consistently with other localization files.The
cannotSubscribeUnrecoverablekey has been added at the correct position within the commerce section, maintaining consistency with the broader localization update.
137-147: SubscriptionDetails object structure matches other localization files.The
subscriptionDetailsobject with all its nested keys (beginsOn,currentBillingCycle,endsOn,nextPaymentAmount,nextPaymentOn,pastDueAt,renewsAt,subscribedOn,title) is properly structured and consistent with the pattern used across other localization files in this update.
151-153: Plan switching keys added with consistent structure.The
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys are positioned correctly and follow the same pattern as other localization files, ensuring consistency across the multilingual implementation.packages/localizations/src/nl-BE.ts (4)
58-59: LGTM: Badge keys for past due status added correctlyThe new badge keys
badge__pastDueAtandbadge__pastDuePlanfollow the existing naming conventions and are appropriately set asundefinedplaceholders for future translation.
81-81: LGTM: Commerce error key added appropriatelyThe new
cannotSubscribeUnrecoverableerror key is correctly positioned within the commerce section and follows the established naming convention.
137-147: LGTM: Comprehensive subscriptionDetails object addedThe new
subscriptionDetailsobject provides comprehensive coverage of subscription lifecycle information with well-named keys. The nested structure is appropriate and follows good organization principles.
151-153: LGTM: Plan switching keys added correctlyThe new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare appropriately named and positioned within the commerce section.packages/localizations/src/el-GR.ts (4)
58-59: LGTM: Badge keys consistently added across localesThe new badge keys
badge__pastDueAtandbadge__pastDuePlanare consistently implemented across localization files, following the established pattern.
81-81: LGTM: Commerce error key consistently implementedThe
cannotSubscribeUnrecoverableerror key is consistently implemented across localization files with appropriate positioning.
137-147: LGTM: SubscriptionDetails object consistently implementedThe
subscriptionDetailsobject is consistently structured across localization files with comprehensive coverage of subscription lifecycle information.
151-153: LGTM: Plan switching keys consistently implementedThe plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare consistently implemented across localization files.packages/localizations/src/it-IT.ts (4)
58-59: LGTM: New badge keys added for past due functionalityThe new badge keys
badge__pastDueAtandbadge__pastDuePlanare properly positioned within the badge section and follow the established pattern of usingundefinedfor untranslated keys.
81-81: LGTM: New commerce error key addedThe new error key
cannotSubscribeUnrecoverableis appropriately placed within the commerce section and follows the established pattern for untranslated keys.
137-147: LGTM: New subscriptionDetails object with comprehensive billing keysThe new
subscriptionDetailsobject contains a well-structured set of keys for subscription billing information. The nested structure follows the established pattern, and all keys are appropriately set toundefinedas placeholders for future translations.
151-151: LGTM: New plan switching keys with pricing informationThe new keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare logically placed within the commerce section and follow the established pattern for untranslated keys.Also applies to: 153-153
packages/localizations/src/be-BY.ts (4)
58-59: LGTM: Consistent badge key additionsThe new badge keys
badge__pastDueAtandbadge__pastDuePlanare consistently implemented across localization files and properly positioned within the badge section.
81-81: LGTM: Consistent commerce error key implementationThe new error key
cannotSubscribeUnrecoverableis consistently implemented across localization files and appropriately placed within the commerce section.
137-147: LGTM: Consistent subscriptionDetails object implementationThe new
subscriptionDetailsobject maintains perfect consistency with other localization files, using the same key structure and undefined placeholders. This consistency is crucial for coordinated feature rollouts.
151-151: LGTM: Consistent plan switching key implementationThe new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricemaintain consistency across localization files and are properly positioned within the commerce section.Also applies to: 153-153
packages/localizations/src/id-ID.ts (4)
58-59: New badge keys added for past due functionality.The addition of
badge__pastDueAtandbadge__pastDuePlankeys follows the established naming convention and structure. Setting them toundefinedas placeholders is appropriate for future translation.
81-81: New commerce error key added.The
cannotSubscribeUnrecoverablekey is properly placed within the commerce object and follows the established camelCase naming convention. The undefined placeholder is appropriate for future translation.
137-147: New subscription details object added.The
subscriptionDetailsobject is well-structured with descriptive camelCase keys for billing cycle information. All keys are appropriately set toundefinedas placeholders for future translation. The nested structure keeps related functionality organized.
151-153: New plan switching keys with price information added.The
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys are well-named and follow the established camelCase convention. The descriptive names indicate they will display plan switching options with pricing information. The undefined placeholders are appropriate for future translation.packages/localizations/src/es-ES.ts (4)
58-59: New badge keys added for past due functionality.The addition of
badge__pastDueAtandbadge__pastDuePlankeys follows the established naming convention and structure. Setting them toundefinedas placeholders is appropriate for future translation and consistent with the coordinated update across all localization files.
81-81: New commerce error key added.The
cannotSubscribeUnrecoverablekey is properly placed within the commerce object and follows the established camelCase naming convention. The undefined placeholder is appropriate for future translation and consistent with the coordinated update.
137-147: New subscription details object added.The
subscriptionDetailsobject is well-structured with descriptive camelCase keys for billing cycle information. All keys are appropriately set toundefinedas placeholders for future translation. The nested structure keeps related functionality organized and is consistent with the coordinated update across all localization files.
151-153: New plan switching keys with price information added.The
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys are well-named and follow the established camelCase convention. The descriptive names indicate they will display plan switching options with pricing information. The undefined placeholders are appropriate for future translation and consistent with the coordinated update.packages/localizations/src/da-DK.ts (4)
58-59: New badge keys added correctly.The new subscription-related badge keys
badge__pastDueAtandbadge__pastDuePlanare properly added as placeholders withundefinedvalues, following the existing naming conventions.
81-81: New commerce error key added correctly.The new
cannotSubscribeUnrecoverableerror key is properly added within the commerce section as a placeholder for future translation.
137-147: New subscriptionDetails object added correctly.The new
subscriptionDetailsnested object with comprehensive billing and subscription keys is properly structured. All keys are appropriately set toundefinedas placeholders for future translation.
151-153: New plan switching keys added correctly.The new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare properly added as placeholders, following the existing naming conventions and positioned appropriately within the commerce section.packages/localizations/src/es-CR.ts (4)
58-59: New badge keys added correctly.The new subscription-related badge keys
badge__pastDueAtandbadge__pastDuePlanare properly added as placeholders withundefinedvalues, following the existing naming conventions and consistent with the cross-language update.
81-81: New commerce error key added correctly.The new
cannotSubscribeUnrecoverableerror key is properly added within the commerce section as a placeholder for future translation, consistent with the cross-language localization update.
137-147: New subscriptionDetails object added correctly.The new
subscriptionDetailsnested object with comprehensive billing and subscription keys is properly structured. All keys are appropriately set toundefinedas placeholders for future translation, consistent with the cross-language update.
151-153: New plan switching keys added correctly.The new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare properly added as placeholders, following the existing naming conventions and positioned appropriately within the commerce section.packages/localizations/src/ca-ES.ts (4)
58-59: LGTM - Badge keys added correctlyThe new badge keys for past due subscription states are properly structured and follow the existing naming conventions. The undefined placeholders are appropriate for this implementation phase.
81-81: LGTM - Commerce error key addedThe new
cannotSubscribeUnrecoverableerror key is properly placed within the commerce section and follows the established naming pattern.
137-147: LGTM - Subscription details object structureThe new
subscriptionDetailsnested object contains all necessary keys for subscription management UI. The structure is well-organized and follows TypeScript interface conventions.
151-153: LGTM - Plan switching keys addedThe new plan switching keys are properly positioned and follow the established naming conventions for commerce-related UI elements.
packages/localizations/src/sv-SE.ts (4)
58-59: LGTM - Badge keys added consistentlyThe new badge keys for past due subscription states are properly structured and match the pattern established in other locale files.
81-81: LGTM - Commerce error key added consistentlyThe new
cannotSubscribeUnrecoverableerror key is properly placed and consistent with other locale files.
137-147: LGTM - Subscription details object structureThe new
subscriptionDetailsnested object is properly structured and consistent with the implementation in other locale files.
151-153: LGTM - Plan switching keys added consistentlyThe new plan switching keys are properly positioned and maintain consistency with other locale files.
packages/localizations/src/fi-FI.ts (1)
58-59: LGTM! Subscription and billing localization placeholders added correctly.The new subscription and billing related keys have been properly added as
undefinedplaceholders, which is appropriate for community-contributed localization files. The changes are additive only and maintain consistency with the existing file structure. These placeholders will allow for proper Finnish translations to be added in the future.Key additions include:
- Badge keys for past due status
- Commerce error for unrecoverable subscription issues
- Subscription details object with billing cycle information
- Plan switching keys with pricing details
Also applies to: 81-81, 137-147, 151-151, 153-153
packages/localizations/src/ro-RO.ts (1)
58-59: LGTM! Consistent subscription and billing localization placeholders added.The Romanian localization file has been updated with the same subscription and billing related keys as other localization files in this PR. All new keys are appropriately set as
undefinedplaceholders, maintaining consistency with the community contribution approach. The changes are additive only and preserve all existing Romanian translations.The additions mirror the pattern seen across other localization files:
- Badge keys for subscription status indicators
- Commerce error handling for subscription issues
- Detailed subscription information object
- Plan switching functionality with pricing
This demonstrates good coordination in the localization update effort.
Also applies to: 81-81, 137-147, 151-151, 153-153
packages/localizations/src/sk-SK.ts (5)
58-59: New badge keys added for subscription status tracking.The addition of
badge__pastDueAtandbadge__pastDuePlanprovides placeholders for displaying past due subscription information. Setting these toundefinedis appropriate as placeholders for future translations.
81-81: New commerce error key for unrecoverable subscription failures.The
cannotSubscribeUnrecoverablekey provides a placeholder for handling subscription errors that cannot be recovered. This addition enhances error handling capabilities in the commerce section.
137-147: New subscriptionDetails object with comprehensive billing lifecycle keys.The addition of the
subscriptionDetailsobject provides placeholders for displaying detailed subscription information including billing cycles, payment dates, and subscription lifecycle events. All keys are appropriately set toundefinedas placeholders.
151-153: New plan switching keys with pricing information.The addition of
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceprovides placeholders for plan switching UI elements that include pricing information. These complement the existing plan switching functionality.
850-850: Minor formatting adjustment to existing key.The
web3_missing_identifierline appears to have been repositioned without content changes, maintaining the existing Slovak translation while improving formatting consistency.packages/localizations/src/ko-KR.ts (4)
58-59: Consistent addition of badge keys for subscription status.The Korean localization receives the same new badge keys (
badge__pastDueAtandbadge__pastDuePlan) as other locales, maintaining consistency across the internationalization updates. Theundefinedvalues are appropriate placeholders.
81-81: Commerce error handling enhancement.The
cannotSubscribeUnrecoverablekey addition aligns with the subscription error handling improvements being applied across all locales. The placeholder value is appropriate.
137-147: Comprehensive subscription details structure added.The new
subscriptionDetailsobject provides the same detailed subscription information structure as other locales, ensuring UI consistency across languages. All nested keys are appropriately set toundefinedas placeholders for future Korean translations.
151-153: Plan switching UI enhancements.The addition of pricing-aware plan switching keys (
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPrice) enhances the subscription management UI capabilities. These additions are consistent with the broader localization update.packages/localizations/src/pt-PT.ts (4)
58-59: New badge keys added for past due subscription statesThe addition of
badge__pastDueAtandbadge__pastDuePlankeys are appropriately placed in the badge section and set as undefined placeholders for future translation.
81-81: New commerce error key for unrecoverable subscription errorsThe
cannotSubscribeUnrecoverablekey is properly added to the commerce section as an undefined placeholder, ready for future translation.
137-147: New subscription details object with comprehensive billing informationThe
subscriptionDetailsobject contains all necessary keys for subscription billing cycles, payment information, and subscription lifecycle management. All keys are properly set as undefined placeholders.
151-153: New plan switching keys with pricing informationThe addition of
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys provides specific pricing context for plan switching UI elements. Both are appropriately set as undefined placeholders.packages/localizations/src/is-IS.ts (4)
58-59: Consistent badge key additions for subscription statesThe
badge__pastDueAtandbadge__pastDuePlankeys are consistently added in the same structure as other localization files, properly set as undefined placeholders.
81-81: Commerce error key properly addedThe
cannotSubscribeUnrecoverablekey maintains consistency with other localization files and is appropriately set as an undefined placeholder.
137-147: Subscription details object structure maintainedThe
subscriptionDetailsobject follows the same comprehensive structure as other localization files, ensuring consistency across all supported languages.
151-153: Plan switching keys consistently implementedThe
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys are properly added in the same positions as other localization files, maintaining structural consistency.packages/localizations/src/zh-TW.ts (6)
58-59: New badge keys added correctly.The new badge keys
badge__pastDueAtandbadge__pastDuePlanare properly structured and follow the existing naming convention. Setting them toundefinedis appropriate for placeholder values pending translation.
81-81: New commerce error key added correctly.The new
cannotSubscribeUnrecoverableerror key is properly placed within the commerce object and follows the established naming pattern.
137-147: Subscription details object structure is well-organized.The new
subscriptionDetailsnested object contains comprehensive keys for billing cycle information. The structure is logical and follows TypeScript object conventions. All keys are appropriately set toundefinedas placeholders.
151-153: Plan switching keys added consistently.The new keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare properly positioned within the commerce object and follow the established naming convention.
240-246: Minor formatting improvements noted.The indentation and spacing in the
organizationListsection have been improved for better readability while maintaining all existing translations.
844-844: Password complexity key added properly.The new
repeatedkey in the password complexity suggestions follows the existing structure and is appropriately set toundefined.packages/localizations/src/nb-NO.ts (5)
58-59: Badge keys added consistently across localizations.The new badge keys
badge__pastDueAtandbadge__pastDuePlanmatch the structure used in other localization files, maintaining consistency across the codebase.
81-81: Commerce error key properly integrated.The
cannotSubscribeUnrecoverableerror key is correctly placed within the commerce object, maintaining the established structure.
137-147: Subscription details structure maintains consistency.The
subscriptionDetailsnested object with its comprehensive set of billing-related keys follows the same structure as other localization files, ensuring consistency across the internationalization system.
151-153: Plan switching keys properly positioned.The new plan switching keys are correctly placed and follow the established naming conventions, maintaining consistency with the overall localization structure.
1-1244: Comprehensive localization update successfully implemented.This coordinated update across localization files properly introduces new subscription and billing-related keys while preserving all existing translations. The use of
undefinedplaceholders is appropriate for this type of coordinated rollout, allowing for systematic translation of new features.All changes follow the established patterns and coding guidelines for localization files. No existing functionality is impacted, and the structure maintains consistency across the internationalization system.
packages/localizations/src/en-GB.ts (4)
58-59: LGTM: Badge keys for past due status indicators added correctly.The new badge keys
badge__pastDueAtandbadge__pastDuePlanfollow the established naming conventions and are appropriately set as undefined placeholders for the en-GB locale.
81-81: LGTM: Commerce error key added appropriately.The new
cannotSubscribeUnrecoverableerror key is properly placed within the commerce section and correctly set as an undefined placeholder for the en-GB locale.
137-147: LGTM: Comprehensive subscription details object added.The new
subscriptionDetailsobject provides a well-structured set of keys for subscription lifecycle management, including billing dates, payment amounts, and subscription states. All keys are appropriately set as undefined placeholders.
151-153: LGTM: Plan switching keys added correctly.The new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare well-named and appropriately set as undefined placeholders for the en-GB locale.packages/localizations/src/cs-CZ.ts (5)
59-60: LGTM: Czech badge translations are accurate and well-formatted.The Czech translations for the past due badge keys are appropriate:
badge__pastDueAtproperly uses Czech date formatting withshortDate('cs-CZ')badge__pastDuePlanuses correct Czech terminology for "past due"Both translations follow the established pattern and use proper Czech grammar.
84-84: LGTM: Commerce error key appropriately left as undefined placeholder.The
cannotSubscribeUnrecoverablekey is correctly set as undefined, indicating a translation is not yet available. This is consistent with the pattern in other localization files.
138-158: LGTM: Subscription details translations are accurate and well-organized.The Czech translations for the subscription details are appropriate and use proper terminology:
beginsOn: "Začíná dne" (Begins on)nextPaymentAmount: "Výše další platby" (Next payment amount)renewsAt: "Obnovuje se dne" (Renews on)subscribedOn: "Předplaceno dne" (Subscribed on)The logical reordering of keys and comprehensive translations demonstrate good localization practice.
155-155: LGTM: Plan switching translation is accurate and properly formatted.The Czech translation for
switchToAnnualWithAnnualPrice("Přepnout na roční {{currency}}{{price}} / rok") correctly handles currency and price placeholders while using proper Czech terminology for annual billing.
1255-1255: LGTM: 'as const' assertion improves type safety.The addition of
as constassertion ensures the localization resource is treated as readonly and provides better TypeScript type inference, which is a good practice for localization resources..changeset/huge-wolves-hunt.md (1)
1-6: LGTM: Changeset properly documents the Serbian localization addition.The changeset correctly specifies:
- Package:
@clerk/localizations- Change type:
patch(appropriate for adding new localization)- Clear description of adding
sr-RSto exported localizationsThis follows the established changeset format and conventions.
packages/localizations/src/index.ts (3)
21-21: LGTM: hrHR export correctly repositioned for alphabetical order.The
hrHRexport has been properly moved to maintain alphabetical order betweenhiINandhuHU.
35-35: LGTM: ptBR export correctly repositioned for alphabetical order.The
ptBRexport has been properly moved to maintain alphabetical order afterplPL.
40-40: LGTM: Serbian localization export properly added.The new
srRSexport is correctly positioned betweenskSKandsvSE, maintaining alphabetical order and following the established export pattern.packages/localizations/src/utils/generate.ts (2)
26-26: LGTM: Spanish (Uruguay) import correctly addedThe import for
esUYis properly placed in alphabetical order among the other Spanish locale imports.
185-185: LGTM: Spanish (Uruguay) generation correctly integratedThe
run()call foresUYis properly placed in the execution sequence, ensuring the Spanish (Uruguay) localization is included in the alignment, sorting, and file generation process.packages/localizations/src/en-US.ts (5)
47-48: LGTM: Past due badge strings addedThe new badge strings for past due subscriptions follow the established pattern and use consistent date formatting with other badge entries.
72-73: LGTM: Commerce error key addedThe new
cannotSubscribeUnrecoverablekey provides a clear error message for subscription conflicts and follows the established naming convention.
127-129: LGTM: New commerce action keys addedThe new keys
reSubscribe,seeAllFeatures, andsubscribeprovide clear, concise labels for subscription-related actions.
130-140: LGTM: Subscription details section reorganizedThe subscription details keys are logically organized and use consistent naming conventions. The reordering improves the logical flow of subscription information.
144-144: LGTM: Plan switching key with pricingThe
switchToAnnualWithAnnualPricekey is correctly positioned and provides a clear template for annual plan switching with price information.packages/localizations/src/sr-RS.ts (4)
58-59: LGTM: Past due badge keys added as placeholdersThe new badge keys for past due subscriptions are correctly added as undefined placeholders, following the established pattern for community-contributed localizations.
81-81: LGTM: Commerce error key added as placeholderThe
cannotSubscribeUnrecoverablekey is correctly added as an undefined placeholder for future translation.
137-147: LGTM: Subscription details section addedThe new
subscriptionDetailsobject with all its keys is correctly structured and matches the en-US file. All keys are appropriately set to undefined for future translation.
151-153: LGTM: Plan switching keys added as placeholdersThe new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare correctly added as undefined placeholders.packages/localizations/src/es-MX.ts (4)
58-59: LGTM: Badge keys added correctlyThe new badge keys
badge__pastDueAtandbadge__pastDuePlanare properly added as undefined placeholders, consistent with the community-maintained localization approach.
81-81: LGTM: Commerce error key addedThe new
cannotSubscribeUnrecoverablekey is properly added as a placeholder for subscription error handling.
137-147: LGTM: Subscription details object structureThe new
subscriptionDetailsobject with its nested keys (beginsOn, currentBillingCycle, endsOn, etc.) is well-structured and follows the established localization pattern. All keys are appropriately set as undefined placeholders.
151-153: LGTM: Plan switching keys addedThe new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare properly added as undefined placeholders for future translation.packages/localizations/src/nl-NL.ts (4)
58-59: LGTM: Consistent badge keys additionThe new badge keys
badge__pastDueAtandbadge__pastDuePlanare properly added as undefined placeholders, maintaining consistency with the broader localization update.
81-81: LGTM: Commerce error key added consistentlyThe
cannotSubscribeUnrecoverablekey is properly added as a placeholder, consistent with the pattern across other localization files.
137-147: LGTM: Subscription details structure maintainedThe new
subscriptionDetailsobject with its nested keys follows the same structure as other localization files in this update. All keys are appropriately set as undefined placeholders for future translation.
151-153: LGTM: Plan switching keys consistentThe new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare properly added as undefined placeholders, maintaining consistency across the localization update.packages/localizations/src/pt-BR.ts (4)
58-59: LGTM: New badge keys added as placeholdersThe new badge keys
badge__pastDueAtandbadge__pastDuePlanhave been correctly added as undefined placeholders for future translation work related to subscription billing status.
83-83: LGTM: New commerce error key added as placeholderThe new commerce error key
cannotSubscribeUnrecoverablehas been correctly added as an undefined placeholder for future translation work related to unrecoverable subscription errors.
141-151: LGTM: New subscription details structure added as placeholdersThe new nested
subscriptionDetailsobject has been correctly added with comprehensive keys for subscription lifecycle management. All keys are appropriately set to undefined as placeholders for future translation work.
155-157: LGTM: New plan switching keys added as placeholdersThe new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricehave been correctly added as undefined placeholders for future translation work related to plan switching UI with pricing information.packages/localizations/src/hr-HR.ts (4)
58-59: LGTM: New badge keys added as placeholdersThe new badge keys
badge__pastDueAtandbadge__pastDuePlanhave been correctly added as undefined placeholders, consistent with the existing pattern in this Croatian localization file.
81-81: LGTM: New commerce error key added as placeholderThe new commerce error key
cannotSubscribeUnrecoverablehas been correctly added as an undefined placeholder, consistent with the existing pattern in this Croatian localization file.
137-147: LGTM: New subscription details structure added as placeholdersThe new nested
subscriptionDetailsobject has been correctly added with comprehensive keys for subscription lifecycle management. All keys are appropriately set to undefined as placeholders, consistent with the existing pattern in this Croatian localization file.
151-153: LGTM: New plan switching keys added as placeholdersThe new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricehave been correctly added as undefined placeholders, consistent with the existing pattern in this Croatian localization file.packages/localizations/src/pl-PL.ts (4)
58-59: New badge keys added correctly.The new badge keys
badge__pastDueAtandbadge__pastDuePlanare properly positioned within the badge section and follow the established naming convention. Usingundefinedas placeholders is appropriate for untranslated keys.
81-81: New commerce error key added correctly.The new
cannotSubscribeUnrecoverablekey is properly positioned within the commerce section and follows the established pattern for error keys.
137-147: Subscription details object added correctly.The new
subscriptionDetailsnested object is well-structured with appropriate keys for subscription lifecycle management. All keys are properly set toundefinedas placeholders and follow the established camelCase naming convention.
151-153: Plan switching keys with pricing added correctly.The new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare properly positioned within the commerce section and follow the established naming convention. These keys appear to provide enhanced plan switching options with pricing details.packages/localizations/src/ja-JP.ts (4)
58-59: Badge keys added consistently.The new badge keys
badge__pastDueAtandbadge__pastDuePlanare properly added and consistent with the changes made across other localization files. Theundefinedplaceholders are appropriate for untranslated keys.
81-81: Commerce error key added consistently.The new
cannotSubscribeUnrecoverablekey is properly positioned within the commerce section and matches the pattern established across other localization files.
137-147: Subscription details object added consistently.The new
subscriptionDetailsnested object matches the structure added to other localization files and provides a logical grouping for subscription-related UI text. All keys are properly set toundefinedas placeholders.
151-153: Plan switching keys added consistently.The new plan switching keys
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPriceare properly positioned and consistent with the changes made across other localization files. The keys provide enhanced plan switching options with pricing details.packages/localizations/src/zh-CN.ts (4)
58-59: New badge keys added for past due subscription status.The addition of
badge__pastDueAtandbadge__pastDuePlanprovides placeholders for subscription billing status badges. These are properly set to undefined as placeholders for future Chinese translations.
81-81: New commerce error key for unrecoverable subscription failures.The
cannotSubscribeUnrecoverablekey provides a placeholder for error messages when subscription operations cannot be recovered. This follows the established pattern for error handling in the commerce section.
137-147: New subscriptionDetails object with comprehensive billing information.The addition of the nested
subscriptionDetailsobject with keys for billing cycle information (beginsOn,currentBillingCycle,endsOn,nextPaymentAmount,nextPaymentOn,pastDueAt,renewsAt,subscribedOn,title) provides a complete structure for subscription management UI. All keys are properly set to undefined as placeholders.
151-153: New plan switching keys with price information.The addition of
switchToAnnualWithAnnualPriceandswitchToMonthlyWithPricekeys provides placeholders for plan switching UI elements that include pricing details. These complement the existingswitchToAnnualandswitchToMonthlykeys.packages/localizations/src/he-IL.ts (4)
58-59: Consistent addition of past due badge keys.The Hebrew localization file correctly includes the same new badge keys (
badge__pastDueAt,badge__pastDuePlan) as other localization files in this update. These are properly set to undefined as placeholders for future Hebrew translations.
81-81: Consistent commerce error key addition.The
cannotSubscribeUnrecoverablekey is consistently added across all localization files in this update, maintaining uniform structure for error handling.
137-147: Well-structured subscriptionDetails object.The nested
subscriptionDetailsobject with comprehensive billing information keys matches the structure implemented across all localization files. This provides a complete foundation for subscription management UI translations.
151-153: Consistent plan switching enhancements.The addition of price-aware plan switching keys (
switchToAnnualWithAnnualPrice,switchToMonthlyWithPrice) maintains consistency with the broader localization update and enhances the subscription management interface.packages/localizations/src/es-UY.ts (13)
1-11: Community contribution disclaimer is appropriate and well-formatted.The disclaimer clearly communicates that this is a community-contributed localization file that may not be officially maintained by Clerk. This transparency is important for users to understand the support level and accuracy expectations.
17-49: NewapiKeyssection structure looks correct.The new API keys section includes all necessary keys for API key management functionality with proper nesting structure. All keys are appropriately set to
undefinedas placeholders for future Spanish (Uruguay) translations.
51-67: New badge keys added consistently.The new badge keys (
badge__activePlan,badge__canceledEndsAt,badge__currentPlan,badge__endsAt,badge__expired,badge__pastDueAt,badge__pastDuePlan,badge__renewsAt,badge__startsAt,badge__upcomingPlan) are properly integrated with existing badge translations and maintain consistent naming conventions.
69-158: Comprehensivecommercesection structure is well-organized.The commerce section includes all necessary keys for subscription and billing functionality:
- Payment methods and checkout flow
- Subscription management and details
- Pricing and billing cycles
- Plan switching functionality
The nested structure follows good organization practices and all keys are appropriately set to
undefinedas placeholders.
175-175: New alternative phone code provider footer link added.The
footerActionLink__alternativePhoneCodeProviderkey is correctly added as a placeholder for future translation.
190-209: API key form field placeholders and labels added consistently.The form field placeholders and labels for API key management follow the established naming pattern and are properly structured for future translation.
254-318: Organization profile billing and API keys sections well-structured.The new sections in
organizationProfileinclude:
apiKeysPagewith proper title placeholderbillingPagewith comprehensive subsections for payment history, payment sources, statements, and subscriptions- All sections follow consistent naming conventions and structure
376-388: Organization navbar additions are consistent.The new navbar items (
apiKeys,billing) and plans page are properly integrated with existing navigation structure.
492-524: Reverification passkey section added appropriately.The new passkey section in reverification follows the established pattern with proper nesting and placeholder values.
574-579: Alternative phone code provider sections added consistently.The
alternativePhoneCodeProvidersections are added consistently acrosssignIn,signUp, and their respective start sections, all with appropriate placeholder values.Also applies to: 688-693, 707-711, 783-788
903-979: User profile billing and API keys sections mirror organization structure.The user profile sections (
apiKeysPage,billingPage,plansPage) mirror the organization profile structure, maintaining consistency across the application. The navbar additions are also consistent.Also applies to: 1087-1088, 1126-1128
1192-1192: Minor text refinements in existing sections.The passkey section primary button text was slightly refined, and a web3 wallet detail action was set to
undefined. These changes maintain consistency with the overall update pattern.Also applies to: 1219-1219
1-1258: ✅ es-UY locale integration verified
Thees-UYlocale is correctly imported and registered inpackages/localizations/src/utils/generate.tsand exported inpackages/localizations/src/index.ts. No further changes are needed.
Description
This the finale to an effort to bring all user-submitted localization PRs up-to-date and get them merged!
While going through a number of tasks for each PR, I noticed that some of the localizations weren't accounted for in the generation script and sometimes, exports.
This PR aims to correct that.
USER-2394
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
New Features
Style