Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable #_calling: in hover #1954

Closed
nbogart-relay opened this issue Jan 23, 2025 · 3 comments · Fixed by #1955
Closed

Disable #_calling: in hover #1954

nbogart-relay opened this issue Jan 23, 2025 · 3 comments · Fixed by #1955
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nbogart-relay
Copy link

Is your feature request related to a problem? Please describe.
As implemented after discussion in #1281, hovering a local shows a line indicating the surrounding calling context:

(defn fo|o-bar [x]
  (+ x x))

Requesting hover will show:

#_calling: clojure.core/defn [name doc-string? attr-map? [params*] prepost-map? body] [name doc-string? attr-map? ([params*] prepost-map? body) + attr-map?]
──────────────────────────────────────────────────────────────────────────────
user/foo-bar
[x]

I don't want or need the first line of information. It is distracting and noisy. If I needed to see the signature of the surrounding call, I'd move to it and look at it, or I'd trigger signatureHelp.

Describe the solution you'd like
Add a config option to not show this.

Describe alternatives you've considered

  1. Do nothing.
  2. change it somehow?

Additional context
I use neovim so I can get hover without editing text, which maybe gives me a different perspective than in other editors where there's no difference. But for me it's very distinct: when I am moving around and reading code, I want only the documentation for a given variable. When I'm editing code, I want the signatureHelp. There's no need for overlap.

@nbogart-relay nbogart-relay added the enhancement New feature or request label Jan 23, 2025
@NoahTheDuke
Copy link
Contributor

Oops, opened this under my work account.

@ericdallo ericdallo added the good first issue Good for newcomers label Jan 24, 2025
@github-project-automation github-project-automation bot moved this to Low priority in clojure-lsp Jan 24, 2025
@ericdallo
Copy link
Member

I agree this could be configurable, we could leverage this existing boolean to check for a :hover :hide-signature-call: flag

@NoahTheDuke
Copy link
Contributor

Cool, I'll take a crack at adding it.

NoahTheDuke added a commit to NoahTheDuke/clojure-lsp that referenced this issue Jan 24, 2025
Defaults to false. If true, doesn't include `#_calling: user/foo [x y z]` at the
start of hover text.

Closes clojure-lsp#1954
ericdallo pushed a commit that referenced this issue Jan 24, 2025
* Add :hover :hide-signature-call setting

Defaults to false. If true, doesn't include `#_calling: user/foo [x y z]` at the
start of hover text.

Closes #1954

* bb lint-fix
@github-project-automation github-project-automation bot moved this from Low priority to Next release in clojure-lsp Jan 24, 2025
@ericdallo ericdallo moved this from Next release to Done in clojure-lsp Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy