Skip to content

Trigger GH workflow after Drone passes #65111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 42 commits into
base: staging
Choose a base branch
from

Conversation

snickell
Copy link
Contributor

@snickell snickell commented Apr 8, 2025

Experiment to see how hard it is to trigger a GH workflow to run after Drone CI passes for a PR:

image

We created a "placeholder" workflow to allow us to test on this branch: #65145 . If we close this PR, we should delete the placeholder file created by that PR.

@snickell
Copy link
Contributor Author

snickell commented Apr 9, 2025

The GH workflow half is working on snickell/test-workflow-dispatch#2:

image

@snickell
Copy link
Contributor Author

snickell commented Apr 9, 2025

@deploy-code-org deploy-code-org changed the title Experiment: trigger GH workflow after Drone passes Trigger GH workflow after Drone passes Apr 9, 2025
.drone.yml Outdated
}
# depends_on:
# - unit
# - ui
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: make sure we uncomment / re-enable depends_on: ['unit', 'ui'] before merging.

@deploy-code-org
Copy link
Contributor

Implemented a more "real" scenario, on-droneci-complete.yml closes the appitools eyes batch when drone is done.

Tested and works in the scenario where drone completes, but GH workflow batches were skipped (no changes to frontend/**)
image

Copy link

github-actions bot commented Apr 10, 2025

🖼️ Storybook Visual Comparison Report

✅ No Storybook eyes differences detected!

@snickell
Copy link
Contributor Author

snickell commented Apr 10, 2025

Tested and works (meaning: throws a visible error) in the (currently unlikely?) scenario where Drone completes before frontend-ci.yml (which in turn invokes component-library.yml and marketing-app-ci.yml).

image image

@snickell
Copy link
Contributor Author

snickell commented Apr 10, 2025

Tested and works when we delay doing the callback from drone for 16 minutes (frontend completes in about 13 minutes). All conditions confirmed, looks like this now works.

image

Copy link
Member

@stephenliang stephenliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a minor suggestion.

snickell and others added 2 commits April 10, 2025 03:55
Co-authored-by: Stephen Liang <stephenliang@users.noreply.github.com>
@snickell snickell marked this pull request as ready for review April 10, 2025 14:01
@snickell snickell requested a review from a team as a code owner April 10, 2025 14:01
@snickell snickell requested a review from a team as a code owner April 18, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy