-
Notifications
You must be signed in to change notification settings - Fork 6
Init #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple small comments - LGTM overall. I'm not that familiar with sonar, so it might be worth also requesting review from someone who has been reviewing the sonar-java PRs (they might have some additional feedback).
README.md
Outdated
[](https://codeclimate.com/github/codeclimate/codeclimate-sonar-php/maintainability) | ||
[](https://codeclimate.com/github/codeclimate/codeclimate-sonar-php/test_coverage) | ||
|
||
`codeclimate-sonar-java` is a Code Climate engine that wraps [Sonarlint](http://www.sonarlint.org) in standalone mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be codeclimate-sonar-php
right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely!
README.md
Outdated
Ignore issues with severity below the minimum: | ||
``` | ||
engines: | ||
sonar-java: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment here: this should be sonar-php
?
No description provided.