Add extraction of meta_site_name #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelucas
reviewed
Oct 26, 2018
newspaper/outputformatters.py
Outdated
| """ | ||
|
|
||
| NON_MEDIA_CLASSES = ('zn-body__read-all', ) |
There was a problem hiding this comment.
I merged your other commit, can you rebase so these changes don't show?
There was a problem hiding this comment.
sure thing - changed!
cf5382f to
db9877f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
we found out that very often it's useful to extract not only source_url, but also site_name (from Open Graph protocol). While this is available from meta_data, we thought that it might be convinent to have it as a property on the article itself and following PR adds that functionality.
Regards,
Piotr