refactor: return 410 GONE for deprecated endpoints and restrict old CLI to only codemod run
#1565
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
commit: |
.changeset/three-bats-glow.md
Outdated
| "@codemod-com/backend": major | ||
| "codemod": major |
There was a problem hiding this comment.
We should make this a minor or patch version upgrade. We also don't need to bump backend.
| "@codemod-com/backend": major | |
| "codemod": major | |
| "codemod": patch |
There was a problem hiding this comment.
@mohebifar done
| Reply: ApiResponse<CreateAPIKeyResponse>; | ||
| }> = async (request: UserDataPopulatedRequest, reply) => { | ||
| return reply.code(410).send({ | ||
| errorText: | ||
| "This endpoint is no longer supported. Please use the new CLI instead.", | ||
| error: GONE, |
There was a problem hiding this comment.
I don't think we need to block any of the API key endpoints
There was a problem hiding this comment.
@mohebifar fixed
apps/backend/src/publishHandler.ts
Outdated
| return reply.code(410).send({ | ||
| errorText: | ||
| "This endpoint is no longer supported. Please use the new CLI instead.", | ||
| error: GONE, |
There was a problem hiding this comment.
This is incorrect. We need to prevent publishing "new codemods". But releasing a new version for the "existing codemods" should be allowed.
This is preventing any publish command.
There was a problem hiding this comment.
@mohebifar done
apps/backend/src/unpublishHandler.ts
Outdated
| return reply.code(410).send({ | ||
| error: | ||
| "This endpoint is no longer supported. Please use the new CLI instead.", |
There was a problem hiding this comment.
Un-publishing should be allowed even encouraged 😁
There was a problem hiding this comment.
@mohebifar done
apps/cli/src/main.ts
Outdated
| import { handleLoginCliCommand } from "#commands/login.js"; | ||
| import { handleLogoutCliCommand } from "#commands/logout.js"; |
There was a problem hiding this comment.
We still need login, logout, publish, unpublish, whoami, list.
For the publish endpoint, when the endpoints returns GONE code, we'll need to show the deprecation warning
There was a problem hiding this comment.
@mohebifar done
8b10dc0 to
a6e1c29
Compare
…nd and send feedback
a6e1c29 to
4ac01c4
Compare
📚 Description
This PR introduces a breaking change by:
410 GONEHTTP error.codemod run.These changes aim to clean up legacy functionality, reduce confusion for users, and encourage the use of supported interfaces only.
🧪 Test Plan
410 GONEresponse with the correct message.codemod runis allowed.