fix: fix storybook tests

jaaydenh · jaaydenh · commit a2358bf2a931 · 2025-07-28T20:22:22.000Z
diff --git a/site/src/modules/workspaces/ClassicParameterFlowDeprecationWarning/ClassicParameterFlowDeprecationWarning.test.tsx b/site/src/modules/workspaces/ClassicParameterFlowDeprecationWarning/ClassicParameterFlowDeprecationWarning.test.tsx
@@ -15,6 +15,7 @@ describe("ClassicParameterFlowDeprecationWarning", () => {
 	it("renders warning when enabled and user has template update permissions", () => {
 		render(
 			<ClassicParameterFlowDeprecationWarning
+				templateSettingsLink={`/templates/${defaultProps.organizationName}/${defaultProps.templateName}/settings`}
 				{...defaultProps}
 				isEnabled={true}
 			/>,
@@ -27,6 +28,7 @@ describe("ClassicParameterFlowDeprecationWarning", () => {
 	it("does not render when enabled is false", () => {
 		const { container } = render(
 			<ClassicParameterFlowDeprecationWarning
+				templateSettingsLink={`/templates/${defaultProps.organizationName}/${defaultProps.templateName}/settings`}
 				{...defaultProps}
 				isEnabled={false}
 			/>,
diff --git a/site/src/modules/workspaces/ClassicParameterFlowDeprecationWarning/ClassicParameterFlowDeprecationWarning.tsx b/site/src/modules/workspaces/ClassicParameterFlowDeprecationWarning/ClassicParameterFlowDeprecationWarning.tsx
@@ -1,28 +1,20 @@
 import { Alert } from "components/Alert/Alert";
 import { Link } from "components/Link/Link";
-import { linkToTemplate, useLinks } from "modules/navigation";
 import type { FC } from "react";
 import { docs } from "utils/docs";
 
 interface ClassicParameterFlowDeprecationWarningProps {
-	organizationName: string;
-	templateName: string;
+	templateSettingsLink: string;
 	isEnabled: boolean;
 }
 
 export const ClassicParameterFlowDeprecationWarning: FC<
 	ClassicParameterFlowDeprecationWarningProps
-> = ({ organizationName, templateName, isEnabled }) => {
-	const getLink = useLinks();
-
+> = ({ templateSettingsLink, isEnabled }) => {
 	if (!isEnabled) {
 		return null;
 	}
 
-	const templateSettingsLink = `${getLink(
-		linkToTemplate(organizationName, templateName),
-	)}/settings`;
-
 	return (
 		<Alert severity="warning" className="mb-2">
 			<div>
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx
@@ -3,6 +3,7 @@ import type { Meta, StoryObj } from "@storybook/react";
 import { within } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 import { chromatic } from "testHelpers/chromatic";
+import { withDashboardProvider } from "testHelpers/storybook";
 import {
 	MockTemplate,
 	MockTemplateVersionParameter1,
@@ -33,6 +34,7 @@ const meta: Meta<typeof CreateWorkspacePageView> = {
 		onCancel: action("onCancel"),
 		templatePermissions: { canUpdateTemplate: true },
 	},
+	decorators: [withDashboardProvider],
 };
 
 export default meta;
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx
@@ -28,6 +28,7 @@ import { UserAutocomplete } from "components/UserAutocomplete/UserAutocomplete";
 import { type FormikContextType, useFormik } from "formik";
 import type { ExternalAuthPollingState } from "hooks/useExternalAuth";
 import { ExternalLinkIcon } from "lucide-react";
+import { linkToTemplate, useLinks } from "modules/navigation";
 import { ClassicParameterFlowDeprecationWarning } from "modules/workspaces/ClassicParameterFlowDeprecationWarning/ClassicParameterFlowDeprecationWarning";
 import { generateWorkspaceName } from "modules/workspaces/generateWorkspaceName";
 import { type FC, useCallback, useEffect, useMemo, useState } from "react";
@@ -102,6 +103,7 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({
 	onSubmit,
 	onCancel,
 }) => {
+	const getLink = useLinks();
 	const [owner, setOwner] = useState(defaultOwner);
 	const [suggestedName, setSuggestedName] = useState(() =>
 		generateWorkspaceName(),
@@ -265,8 +267,9 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({
 			</PageHeader>
 
 			<ClassicParameterFlowDeprecationWarning
-				organizationName={template.organization_name}
-				templateName={template.name}
+				templateSettingsLink={`${getLink(
+					linkToTemplate(template.organization_name, template.name),
+				)}/settings`}
 				isEnabled={templatePermissions.canUpdateTemplate}
 			/>
 
diff --git a/site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersForm.tsx b/site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersForm.tsx
@@ -90,8 +90,7 @@ export const WorkspaceParametersForm: FC<WorkspaceParameterFormProps> = ({
 				</Alert>
 			)}
 			<ClassicParameterFlowDeprecationWarning
-				organizationName={workspace.organization_name}
-				templateName={workspace.template_name}
+				templateSettingsLink={`/templates/${workspace.organization_name}/${workspace.template_name}/settings`}
 				isEnabled={templatePermissions?.canUpdateTemplate ?? false}
 			/>
 			<HorizontalForm onSubmit={form.handleSubmit} data-testid="form">
