Skip to content

fix(site): standardize headers for Admin Settings page #16911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 1, 2025
Merged

fix(site): standardize headers for Admin Settings page #16911

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
de69ee3
fix: migrate deployment workspace proxies page to new header style
Parkreiner Mar 11, 2025
a1da1c1
fix: update other proxy page to use proper render key values
Parkreiner Mar 11, 2025
e5d581b
fix: make secondary styling more obvious
Parkreiner Mar 11, 2025
9b4928b
refactor: move SettingsHeader to Tailwind
Parkreiner Mar 11, 2025
a35a9ae
fix: resolve header level bugs
Parkreiner Mar 11, 2025
9872c5d
fix: constrain max width
Parkreiner Mar 11, 2025
1fe0022
fix: apply formatting
Parkreiner Mar 13, 2025
7d0903a
fix: update HTML semantics
Parkreiner Mar 13, 2025
a512bf5
fix: flush semantics fix
Parkreiner Mar 13, 2025
734f59d
fix: update leading
Parkreiner Mar 13, 2025
49b9dfe
fix: resolve styling edge case for beta badge
Parkreiner Mar 13, 2025
840d6df
fix: set correct font size
Parkreiner Mar 13, 2025
f169c4e
fix: remove redundant class
Parkreiner Mar 17, 2025
2325982
Merge branch 'main' into mes/headers-fix-b
Parkreiner Mar 28, 2025
99c2dbc
refactor: switch to CVA
Parkreiner Mar 28, 2025
50eddd0
refactor: update API design of SettingsHeader
Parkreiner Mar 28, 2025
2b77784
chore: add first-ever stories for SettingsHeader
Parkreiner Mar 28, 2025
e2523cb
fix: make header more responsive
Parkreiner Mar 28, 2025
7f53666
fix: format
Parkreiner Mar 28, 2025
daf6da9
fix: update beta badge styling for Notifications page
Parkreiner Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: resolve styling edge case for beta badge
  • Loading branch information
@Parkreiner
Parkreiner committed Mar 13, 2025
commit 49b9dfeb4a4b443d6529a36bc45cd51e00a8810e
2 changes: 1 addition & 1 deletion site/src/components/SettingsHeader/SettingsHeader.tsx
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a storybook for it covering the new variants?

Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const SettingsHeader: FC<HeaderProps> = ({
<div className="flex flex-row gap-2 align-middle">
<HeaderTitle
className={twMerge(
"m-0 pb-1 text-3xl font-bold flex align-baseline gap-2 leading-tight",
"m-0 pb-1 text-3xl font-bold flex items-center gap-2 leading-tight",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The different leading values for the header and description are intentional – leading needs to go down the larger your text is

titleVisualHierarchy === "secondary" && "text-2xl font-medium",
)}
>
Expand Down
2 changes: 1 addition & 1 deletion site/src/pages/DeploymentSettingsPage/NotificationsPage/NotificationsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const NotificationsPage: FC = () => {
title={
<>
Notifications
<span css={{ position: "relative", top: "-6px" }}>
<span css={{ position: "relative", top: "2px" }}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to adjust this slightly to account for the updated text leading

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma Apr 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it something we could use CSS variables and calc to make the top value more reliable and easier to understand? By understand I mean, why is it 2px? If not, a comment would be nice.

<FeatureStageBadge
contentType={"beta"}
size="lg"
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy