actually print the diff

coder · johnstcn · Mar 31, 2025 · Mar 21, 2025 · Mar 28, 2025 · Mar 28, 2025
commit a8e908a462a8bb06a9f3d1d94104c77a5640959b
diff --git a/cli/clitest/golden.go b/cli/clitest/golden.go
@@ -13,6 +13,7 @@ import (
 
 	"github.com/google/go-cmp/cmp"
 	"github.com/google/uuid"
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
 	"github.com/coder/coder/v2/cli/config"
@@ -118,9 +119,7 @@ func TestGoldenFile(t *testing.T, fileName string, actual []byte, replacements m
 	require.NoError(t, err, "read golden file, run \"make gen/golden-files\" and commit the changes")
 
 	expected = normalizeGoldenFile(t, expected)
-	if diff := cmp.Diff(string(expected), string(actual)); diff != "" {
-		t.Fatalf("golden file mismatch: %s, run \"make gen/golden-files\", verify and commit the changes", goldenPath)
-	}
+	assert.Empty(t, cmp.Diff(string(expected), string(actual)), "golden file mismatch (-want +got): %s, run \"make gen/golden-files\", verify and commit the changes", goldenPath)
 }
 
 // normalizeGoldenFile replaces any strings that are system or timing dependent