test: add test cases for domain concealment in auth error messages

- Verifies the error message no longer shows domain list - Adds tests for both invalid domain and malformed email cases - Includes test for successful login with allowed domain - Fixes response body closing in test
coder · ericpaulsen · Mar 27, 2025 · Mar 27, 2025 · Mar 27, 2025 · Mar 27, 2025
commit bbdd048969bb5c609566f7b77ab83789256a1a05
diff --git a/coderd/domain_error_test.go b/coderd/domain_error_test.go
@@ -111,7 +111,8 @@ func TestOIDCDomainErrorMessage(t *testing.T) {
 		}
 
 		// Attempt login and expect success
-		client, _ := fake.Login(t, server, claims)
+		client, resp := fake.Login(t, server, claims)
+		defer resp.Body.Close()
 
 		// Verify the user was created correctly
 		user, err := client.User(context.Background(), "me")