chore: don't cache errors in file cache #18555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

aslilac merged 23 commits into main from lilac/dont-cache-errors

Jul 1, 2025

update some comments

Loading branch information

aslilac committed Jul 1, 2025

commit 9cda09f4592c6bf19e2275e8fdcda05133612c60

coderd/files/cache.go

-Original file line number
+Diff line change
@@ Expand Up / @@ -108,6 +108,7 @@ type cacheMetrics struct { @@
     }
     type cacheEntry struct {
+    	// refCount must only be accessed while the Cache lock is held.
     	refCount int
     	value    *lazy.ValueWithError[CacheEntryValue]
@@ Expand Down @@

pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy