feat: prioritize human-initiated workspace builds over prebuilds in queue #18882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ueue This change implements a priority queue system for provisioner jobs to ensure that human-initiated workspace builds are processed before prebuild jobs, improving user experience during high queue periods. Changes: - Add priority column to provisioner_jobs table (1=human, 0=prebuild) - Update AcquireProvisionerJob query to order by priority DESC, created_at ASC - Set priority in workspace builder based on initiator (PrebuildsSystemUserID) - Expose priority field in API and SDK - Add comprehensive test for priority queue behavior Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
johnstcn
requested changes
Jul 21, 2025
There was a problem hiding this comment.
I'd rather not add a new column here, as this requires a migration and migrations are difficult to backport, and this seems like something we would want to backport. We could instead add an explicit CASE WHEN on initiator_id to perform the ordering.
EDIT: can you please also link an associated GH issue, if it exists?
johnstcn
added a commit
that referenced
this pull request
Jul 22, 2025
Continues from #18882 - Reverts extraneous changes - Adds explicit `ORDER BY initiator_id = $PREBUILDS_USER_ID` to `AcquireProvisionerJob` - Improves test added for above PR --------- Co-authored-by: blink-so[bot] <211532188+blink-so[bot]@users.noreply.github.com> Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
|
I guess we can close it now. |
Address review feedback by removing the priority column migration and instead using a CASE WHEN statement in the AcquireProvisionerJob query to prioritize human-initiated jobs over prebuilds. This approach avoids the need for a migration while maintaining the same functionality. Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements a priority queue system for provisioner jobs to ensure human-initiated workspace builds are processed before prebuild jobs, improving user experience during high queue periods.
Changes
AcquireProvisionerJobquery to useCASE WHENoninitiator_idto order by priorityHow it works
AcquireProvisionerJobquery now uses aCASE WHENstatement to prioritize jobs:initiator_id != PrebuildsSystemUserIDget priority 1 (human-initiated)initiator_id = PrebuildsSystemUserIDget priority 0 (prebuilds)Testing
Impact
Related to provisioner queue issues like #15843 and #16488 - this addresses the specific case where prebuilds can delay human-initiated workspace builds during busy periods.