Skip to content

feat(codersdk/toolsdk): add MCP workspace bash background parameter #19034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: thomask33/feat_add_timeout_support_to_workspace_bash_tool
Choose a base branch
from
Open

feat(codersdk/toolsdk): add MCP workspace bash background parameter #19034

wants to merge 2 commits into from

Conversation

hugodutka
Copy link
Contributor

@hugodutka hugodutka commented Jul 24, 2025 •
edited
Loading

Addresses coder/internal#820. I'm not sure how I could go about adding automated tests for this, so I only tested manually.

Screen.Recording.2025-07-24.at.15.11.54.mov

@hugodutka hugodutka requested a review from ThomasK33 July 24, 2025 13:16
@hugodutka hugodutka force-pushed the hugodutka/workspace-bash-bg-param branch from da40c51 to 08c72bf Compare July 24, 2025 14:22
@ThomasK33 Graphite App
Copy link
Member

adding automated tests

Could we add a test (similar to the other ones in bash_test.go), that performs two bash tool calls/handler invocations?
One would launch a python http server on port 8123, and the second handler call would curl that port and check if it received an error.

@hugodutka hugodutka force-pushed the hugodutka/workspace-bash-bg-param branch from 08c72bf to 6463e41 Compare July 24, 2025 16:57
@hugodutka hugodutka changed the base branch from main to thomask33/feat_add_timeout_support_to_workspace_bash_tool July 24, 2025 16:57
@hugodutka hugodutka force-pushed the hugodutka/workspace-bash-bg-param branch from 6463e41 to e61cab7 Compare July 24, 2025 16:57
@hugodutka
Copy link
Contributor Author

@ThomasK33 I didn't know we had setupWorkspaceForAgent! Thanks for spotting. I added integration tests and temporarily rebased onto your timeout branch until its merged. The tests don't spawn a python server though - I don't want to make our test suite depend on python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasK33 ThomasK33 Awaiting requested review from ThomasK33

Assignees

@hugodutka hugodutka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugodutka @ThomasK33
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy