Skip to content

chore: remove soft isolation configurability #19069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025

Conversation

deansheather
Copy link
Member

Undoes a lot of the changes in 5319d47

Keeps the netns.SetCoderSoftIsolation() call, but always sets it to true when using a TUN device.

ethanndickson
ethanndickson previously approved these changes Jul 29, 2025
@ethanndickson ethanndickson dismissed their stale review July 29, 2025 08:08

too hasty

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VPN proto changes look OK to me as the 1.3 changes were only added a few days ago (see 5319d47) and have not yet been released. I don't have sufficient context for the rest of the changes.

@deansheather deansheather merged commit bf78966 into main Jul 29, 2025
69 of 73 checks passed
@deansheather deansheather deleted the dean/vpn-remove-soft-isolation-config branch July 29, 2025 12:30
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy