fix: opt-in tailscale vpn loop prevention #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Jul 28, 2025
| using (await _opLock.LockAsync(ct)) | ||
| // Grab the lock again so we can update the state. Don't use the CT | ||
| // here as it may have already been canceled. | ||
| using (await _opLock.LockAsync(TimeSpan.FromSeconds(5), CancellationToken.None)) |
There was a problem hiding this comment.
This was a bug I noticed on startup when the server was unreachable, it would timeout the CT and then never set the status to "invalid" so the tray window would always be stuck in the loading state
deansheather
added a commit
that referenced
this pull request
Jul 29, 2025
This reverts commit 814b412.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.