Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locating a few tactic datatypes referring to identifiers #13100

Closed

Conversation

herbelin
Copy link
Member

@herbelin herbelin commented Sep 27, 2020

Kind: enhancement

This is part of the project started in #11842.

This should eventually give more precise error locations but there are apparently still some issues with the grain of tactic error reporting. At the current time, this is mostly a step towards #11842.

@herbelin herbelin added part: tactics kind: enhancement Enhancement to an existing user-facing feature, tactic, etc. labels Sep 27, 2020
@herbelin herbelin added this to the 8.13+beta1 milestone Sep 27, 2020
@herbelin herbelin requested review from a team as code owners September 27, 2020 09:30
@github-actions github-actions bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Sep 30, 2020
@herbelin herbelin force-pushed the master+locating-few-tactic-datatypes branch from 8945427 to 0f46807 Compare October 4, 2020 13:26
@coqbot-app coqbot-app bot removed the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Oct 4, 2020
@github-actions github-actions bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Oct 15, 2020
@herbelin herbelin force-pushed the master+locating-few-tactic-datatypes branch from 0f46807 to 090edeb Compare October 19, 2020 08:03
@coqbot-app coqbot-app bot removed the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Oct 19, 2020
@github-actions github-actions bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Oct 27, 2020
@herbelin herbelin force-pushed the master+locating-few-tactic-datatypes branch from 090edeb to a6459a9 Compare October 28, 2020 15:53
@coqbot-app coqbot-app bot removed the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Oct 28, 2020
@herbelin
Copy link
Member Author

I believe that the ongoing discussion at #13102 applies to this PR as well (cc @ppedrot).

@github-actions github-actions bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Nov 5, 2020
@herbelin herbelin force-pushed the master+locating-few-tactic-datatypes branch from a6459a9 to b2bea52 Compare November 16, 2020 12:30
@coqbot-app coqbot-app bot removed the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Nov 16, 2020
@gares
Copy link
Member

gares commented Nov 18, 2020

This PR needs an assignee and a review. If this happens soon I'm OK with porting it to 8.13, if not I'll delay it.

@gares gares modified the milestones: 8.13+beta1, 8.14+beta1 Nov 18, 2020
@github-actions github-actions bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label May 14, 2021
@ppedrot ppedrot modified the milestones: 8.14+rc1, 8.15+rc1 Jun 7, 2021
@coqbot-app
Copy link
Contributor

coqbot-app bot commented Jul 27, 2021

The "needs: rebase" label was set more than 30 days ago. If the PR is not rebased in 30 days, it will be automatically closed.

@coqbot-app coqbot-app bot added the stale This PR will be closed unless it is rebased. label Jul 27, 2021
@coqbot-app
Copy link
Contributor

coqbot-app bot commented Sep 10, 2021

This PR was not rebased after 30 days despite the warning, it is now closed.

@coqbot-app coqbot-app bot closed this Sep 10, 2021
@coqbot-app coqbot-app bot removed this from the 8.15+rc1 milestone Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Enhancement to an existing user-facing feature, tactic, etc. needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. part: tactics stale This PR will be closed unless it is rebased.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy