-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locating a few tactic datatypes referring to identifiers #13100
Closed
herbelin
wants to merge
3
commits into
coq:master
from
herbelin:master+locating-few-tactic-datatypes
Closed
Locating a few tactic datatypes referring to identifiers #13100
herbelin
wants to merge
3
commits into
coq:master
from
herbelin:master+locating-few-tactic-datatypes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 27, 2020
8945427
to
0f46807
Compare
0f46807
to
090edeb
Compare
090edeb
to
a6459a9
Compare
a6459a9
to
b2bea52
Compare
This PR needs an assignee and a review. If this happens soon I'm OK with porting it to 8.13, if not I'll delay it. |
The "needs: rebase" label was set more than 30 days ago. If the PR is not rebased in 30 days, it will be automatically closed. |
This PR was not rebased after 30 days despite the warning, it is now closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind: enhancement
Enhancement to an existing user-facing feature, tactic, etc.
needs: rebase
Should be rebased on the latest master to solve conflicts or have a newer CI run.
part: tactics
stale
This PR will be closed unless it is rebased.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind: enhancement
This is part of the project started in #11842.
This should eventually give more precise error locations but there are apparently still some issues with the grain of tactic error reporting. At the current time, this is mostly a step towards #11842.