Abstract away the representation of module-related types #19995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkySkimmer
approved these changes
Jan 8, 2025
ppedrot
added a commit
to ppedrot/metacoq
that referenced
this pull request
Jan 9, 2025
ppedrot
added a commit
to ppedrot/paramcoq
that referenced
this pull request
Jan 9, 2025
ppedrot
added a commit
to ppedrot/coq-elpi
that referenced
this pull request
Jan 9, 2025
ppedrot
added a commit
to ppedrot/coq-lsp
that referenced
this pull request
Jan 9, 2025
e3fedeb to
c60a616
Compare
After having made them private, we expose accessors for the now hidden fields.
c60a616 to
295212d
Compare
|
@SkySkimmer Now that the 9.0 has branched this is ready. |
ppedrot
added a commit
to ppedrot/coq-elpi
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of exposing these types in Declarations, we move them under an opaque API in Mod_declarations. The underlying implementation has not changed, meanwhile.
This will allow tweaking the internals without fear, in particular ensuring implicit invariants statically and relying on more compact representations to reduce vo file size.
Overlays: