Enable querier execution from logical plan #6908
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe31a41 to
2f83e12
Compare
yeya24
reviewed
Jul 24, 2025
|
An open question: when we expect to execute from a logical plan but receive an empty plan parameter, should we My current implementation does the fallback, but I'm wondering if this masks potential frontend issues we should catch instead |
2f83e12 to
422b1f2
Compare
3 tasks
Signed-off-by: rubywtl <rubyharrisonlee@gmail.com>
Signed-off-by: rubywtl <rubyharrisonlee@gmail.com>
Signed-off-by: rubywtl <rubyharrisonlee@gmail.com>
Signed-off-by: rubywtl <rubyharrisonlee@gmail.com>
…ler code Signed-off-by: rubywtl <rubyharrisonlee@gmail.com>
Signed-off-by: rubywtl <rubyharrisonlee@gmail.com>
a7a4faf to
d984196
Compare
Signed-off-by: rubywtl <rubyharrisonlee@gmail.com>
Signed-off-by: rubywtl <rubyharrisonlee@gmail.com>
yeya24
reviewed
Jul 26, 2025
yeya24
reviewed
Jul 27, 2025
Signed-off-by: rubywtl <rubyharrisonlee@gmail.com>
* add zone label to ring_members metric Signed-off-by: Alex Le <leqiyue@amazon.com> * update changelog Signed-off-by: Alex Le <leqiyue@amazon.com> * fix nil pointer Signed-off-by: Alex Le <leqiyue@amazon.com> --------- Signed-off-by: Alex Le <leqiyue@amazon.com>
…ct#6909) Signed-off-by: Ahmed Hassan <afayekhassan@gmail.com>
…#6873) * Querier: Support configuring optimizers and XFunctions Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com> * Address comments Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com> --------- Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>
### Main fixes applied: 1. **Line 5**: Fixed "long term storage" → "long-term storage" (consistency with hyphenation) 2. **Line 12**: Fixed "Long term storage" → "Long-term storage" (consistency with hyphenation) 3. **Line 126**: Fixed "the AMP" → "AMP" (removed unnecessary article - "the" before abbreviation when referring to the service directly) 4. **Line 126**: Fixed "managed monitoring for your containers" → "managed monitoring service for your containers" (added missing word "service" for clarity) ### Minor grammar improvements: - **Hyphenation consistency**: Made sure "long-term" is consistently hyphenated throughout - **Article usage**: Corrected the use of "the" before abbreviations where it wasn't needed - **Completeness**: Added missing words to make sentences grammatically complete The document now has consistent terminology, proper grammar, and professional language throughout. All the technical content, links, and formatting remain intact while the language is now more polished and consistent. Signed-off-by: Charlie Le <charlie_le@apple.com>
Signed-off-by: rubywtl <rubyharrisonlee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR enables the queriers to execute a logical plan derived from the serialized logical plan in the request body, under the distributed execution feature flag. It includes a fallback to the PromQL engine when necessary.
Unit tests have been added to verify that queries are correctly executed from the logical plan in the request body when expected, as opposed to the query string in the request URL
Which issue(s) this PR fixes:
Addresses the problem outlined in proposal 6789
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]