Skip to content

fix #61 exclude option #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #61 exclude option #62

wants to merge 1 commit into from

Conversation

cxy930123
Copy link

No description provided.

@zhang156
Copy link

+1

@wzdxy
Copy link

wzdxy commented Dec 16, 2020

+1
I spent the whole afternoon debugging this bug.
I found this PR when I was about to modify the source code.

@wzdxy
Copy link

wzdxy commented Dec 16, 2020

When exclude is a function
filePath.match(exclude) always returns null , then all files be excluded

@cuth
Copy link
Owner

cuth commented Dec 16, 2020

Could you write a unit test to support this change?

@defghy
Copy link

defghy commented May 18, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy