Skip to content

Fix #13841 (Update simplecpp to 1.4.1) #7531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Conversation

danmar
Copy link
Owner

@danmar danmar commented May 16, 2025

No description provided.

@danmar danmar merged commit 2074075 into danmar:main May 16, 2025
49 checks passed
@SChernykh
Copy link
Contributor

SChernykh commented May 18, 2025

@danmar After this change, my cppcheck CI job started failing with missingInclude. It looks like that it lost ability to check the include paths - both from compile_commands.json and from --includes-file

@danmar
Copy link
Owner Author

danmar commented May 19, 2025

@SChernykh ouch! I fail to reproduce directly. Would it be possible to create a small minimal example?

Here is a quick test in cppcheck repo:

daniel@laptop:~/cppcheck$ ./cppcheck --project=build/compile_commands.json --file-filter="*cppcheckexecutor.cpp" --enable=missingInclude -D__GNUC__ --suppress=missingIncludeSystem -v
Checking cli/cppcheckexecutor.cpp ...
Defines:__GNUC__=1;FILESDIR="/usr/local/share/Cppcheck";_GLIBCXX_DEBUG=1
Undefines:
Includes: -Ibuild/cli/ -Icli/ -Ilib/ -Iexternals/tinyxml2/ -Iexternals/picojson/ -Iexternals/simplecpp/
Platform:native
Checking cli/cppcheckexecutor.cpp: __GNUC__=1;FILESDIR="/usr/local/share/Cppcheck";_GLIBCXX_DEBUG=1...
cli/cppcheckexecutor.cpp:0:0: information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

^

the source file includes various files in externals and lib.

@SChernykh
Copy link
Contributor

SChernykh commented May 19, 2025

This is the last passed CI check in my repo: https://github.com/SChernykh/p2pool/actions/runs/15063299959
This is the first failed CI check in my repo: https://github.com/SChernykh/p2pool/actions/runs/15080672366

Passed CI check used commit 6d7dc76
Failed CI check used commit 69a11d6

So somewhere between these two commits things got broken. I suspect it was this one, because other commits only touch tests.

Edit: and I didn't do any commits between these two CI runs - the second run was a nightly scheduled check.
Edit2: my CI run file is https://github.com/SChernykh/p2pool/blob/master/.github/workflows/cppcheck.yml and it uses files from https://github.com/SChernykh/p2pool/tree/master/cppcheck

@danmar
Copy link
Owner Author

danmar commented May 19, 2025

@Tal500 would it be possible for you to take a look if this is related to your changes?

@Tal500
Copy link

Tal500 commented May 19, 2025

@Tal500 would it be possible for you to take a look if this is related to your changes?

Yes, I'll try to look on thus tomorrow

@Tal500
Copy link

Tal500 commented May 21, 2025

Fixed in #429

@SChernykh
Copy link
Contributor

When is simplecpp going to be updated here? It's still giving me the same error because code is not updated.

@danmar
Copy link
Owner Author

danmar commented May 30, 2025

the fix has not been merged in simplecpp yet:
danmar/simplecpp#429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy