Fix #454: Accept __has_include for GNU C standards #456
Conversation
| std::list<std::string> defines; | ||
| std::set<std::string> undefined; | ||
| std::list<std::string> includePaths; | ||
| std::list<std::string> includes; | ||
| std::string std; | ||
| bool gnu; |
There was a problem hiding this comment.
not a very strong opinion but if gnu is a method instead then std and gnu can't mismatch. i.e.:
bool gnu() const {
return std.rfind("gnu",0) == 0;
}
There was a problem hiding this comment.
cppcheck removes the "gnu" when creating the DUI:
// TODO: use mSettings.standards.stdValue instead
if (lang == Standards::Language::CPP) {
dui.std = mSettings.standards.getCPP();
...I'm not sure why mSettings.standards.stdValue is not used and is only a TODO here, but currently I think we need to have the gnu boolean, since cppcheck would turn for example gnu++11 in to c++11.
There was a problem hiding this comment.
I'm not sure why
mSettings.standards.stdValueis not used and is only a TODO here
Because I do not want to change stuff without having a test case and try to make dedicated fixes instead of drive-by ones - so I keep dropping TODOs in the code. And I keep getting distracted by too much other stuff...
There was a problem hiding this comment.
simplecpp should set __STRICT_ANSI__=1 if a non-gnu standard is provided. With that in-place we can write a test that makes sure that Cppcheck passes on the proper standards string.
No description provided.