add w3schools to detector-hints.config #14498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderby
reviewed
Jul 21, 2025
| w3schools.com | ||
|
|
||
| TARGET | ||
| html |
There was a problem hiding this comment.
There was a mistake. The target should have been body, the elements which the detector should wait for.
There was a problem hiding this comment.
This shouldn't be interfering the functionality, but thanks for correcting . I'll change it in next pull request.
There was a problem hiding this comment.
It wouldn't work because the root html element cannot match body selector. I already committed the change, so no need for another fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added w3schools in detector-hints.config file. Now it detects dark theme also it will not override its dark theme.