Skip to content

Update the output and readin of electronic wave functions in plane wave basis set #6223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
May 19, 2025

Conversation

mohanchen
Copy link
Collaborator

Update the output and readin of electronic wave functions in plane wave basis set

@mohanchen mohanchen requested a review from AsTonyshment May 17, 2025 09:18
@mohanchen mohanchen added Input&Output Suitable for coders without knowing too many DFT details The Absolute Zero Reduce the "entropy" of the code to 0 Unit Tests/Integreate Tests Issues/PR related to unit tests and integrate tests labels May 17, 2025
Copy link
Collaborator

@AsTonyshment AsTonyshment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the source/Makefile.Objects file needs to be modified as well to let the makefile test pass. Adding filename.o\ to the OBJS_IO list might be worth a shot .

@AsTonyshment AsTonyshment self-requested a review May 19, 2025 01:47
Copy link
Collaborator

@AsTonyshment AsTonyshment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mohanchen mohanchen merged commit f158182 into deepmodeling:develop May 19, 2025
14 checks passed
kluophysics pushed a commit to kluophysics/abacus-develop that referenced this pull request May 25, 2025
…ve basis set (deepmodeling#6223)

* update the readin wave function information

* remove the extra write_wfc_pw in esolver_ks_pw

* let GPU OW test passes

* update the output formats of pw wave functions

* update pw readin wf, found 2 places that read in wave functions, need to be refactored in near future

* update 055 example

* update doc

* update input files and fix compilation error

* update input-main.md

* update 090 example

* update 090 example

* update some tests in 01

* update CASES

* update file names in 08_EXX example

* I found read_wfc_lcao code and the corresponding tests are useless

* update test.yml

* update read_wf2rho_pw function and tests

* rewrite the input variables for write_wfc_pw

* update read_wfc_pw

* remove ofs_running info

* fix read_wf2rho_pw_test.cpp

* fix bug

* update read_input_ptest.cpp test

* add back wfs1k1_pw.dat

* update 055_PW_OW result.ref
kluophysics pushed a commit to kluophysics/abacus-develop that referenced this pull request May 25, 2025
…ve basis set (deepmodeling#6223)

* update the readin wave function information

* remove the extra write_wfc_pw in esolver_ks_pw

* let GPU OW test passes

* update the output formats of pw wave functions

* update pw readin wf, found 2 places that read in wave functions, need to be refactored in near future

* update 055 example

* update doc

* update input files and fix compilation error

* update input-main.md

* update 090 example

* update 090 example

* update some tests in 01

* update CASES

* update file names in 08_EXX example

* I found read_wfc_lcao code and the corresponding tests are useless

* update test.yml

* update read_wf2rho_pw function and tests

* rewrite the input variables for write_wfc_pw

* update read_wfc_pw

* remove ofs_running info

* fix read_wf2rho_pw_test.cpp

* fix bug

* update read_input_ptest.cpp test

* add back wfs1k1_pw.dat

* update 055_PW_OW result.ref
kluophysics pushed a commit to kluophysics/abacus-develop that referenced this pull request May 25, 2025
…ve basis set (deepmodeling#6223)

* update the readin wave function information

* remove the extra write_wfc_pw in esolver_ks_pw

* let GPU OW test passes

* update the output formats of pw wave functions

* update pw readin wf, found 2 places that read in wave functions, need to be refactored in near future

* update 055 example

* update doc

* update input files and fix compilation error

* update input-main.md

* update 090 example

* update 090 example

* update some tests in 01

* update CASES

* update file names in 08_EXX example

* I found read_wfc_lcao code and the corresponding tests are useless

* update test.yml

* update read_wf2rho_pw function and tests

* rewrite the input variables for write_wfc_pw

* update read_wfc_pw

* remove ofs_running info

* fix read_wf2rho_pw_test.cpp

* fix bug

* update read_input_ptest.cpp test

* add back wfs1k1_pw.dat

* update 055_PW_OW result.ref
kluophysics pushed a commit to kluophysics/abacus-develop that referenced this pull request May 25, 2025
…ve basis set (deepmodeling#6223)

* update the readin wave function information

* remove the extra write_wfc_pw in esolver_ks_pw

* let GPU OW test passes

* update the output formats of pw wave functions

* update pw readin wf, found 2 places that read in wave functions, need to be refactored in near future

* update 055 example

* update doc

* update input files and fix compilation error

* update input-main.md

* update 090 example

* update 090 example

* update some tests in 01

* update CASES

* update file names in 08_EXX example

* I found read_wfc_lcao code and the corresponding tests are useless

* update test.yml

* update read_wf2rho_pw function and tests

* rewrite the input variables for write_wfc_pw

* update read_wfc_pw

* remove ofs_running info

* fix read_wf2rho_pw_test.cpp

* fix bug

* update read_input_ptest.cpp test

* add back wfs1k1_pw.dat

* update 055_PW_OW result.ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Input&Output Suitable for coders without knowing too many DFT details The Absolute Zero Reduce the "entropy" of the code to 0 Unit Tests/Integreate Tests Issues/PR related to unit tests and integrate tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy